Added feature for locking host memory #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you make it go to a branch first? also it would be good if a unit test in hcc layer be provided. |
|
Hi, |
|
@adityaatluri Please place them under tests/Unit directory. You may want to discuss with @facao on a common directory name as both of you are working on AM-related features. |
| @@ -155,5 +155,9 @@ void am_memtracker_print(); | |||
| void am_memtracker_sizeinfo(const hc::accelerator &acc, size_t *deviceMemSize, size_t *hostMemSize, size_t *userMemSize); | |||
|
|
|||
|
|
|||
| am_status_t am_memtracker_host_memory_lock(hc::accelerator &acc, void *ptr, size_t size); | |||
There was a problem hiding this comment.
@adityaatluri As these two new functions are public APIs and would supposedly be invoked by user applications, could you help provide some comments for them?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.