Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU link - support linking static library #2

Merged
merged 8 commits into from
Mar 28, 2016
Merged

GPU link - support linking static library #2

merged 8 commits into from
Mar 28, 2016

Conversation

scchan
Copy link
Collaborator

@scchan scchan commented Mar 27, 2016

No description provided.

whchung
whchung reviewed Mar 28, 2016
View reviewed changes
lib/clamp-link.in
echo "cpufile: $CPUFILE"
echo "iscrt: $ISCRT"
echo "islib: $ISLIB"
echo ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugging-only lines should be commented out.

@whchung whchung merged commit 30418b8 into ROCm:master Mar 28, 2016
whchung
whchung reviewed Mar 30, 2016
View reviewed changes
lib/clamp-link.in
mkdir -p $AR_TEMP_DIR
TEMP_AR_DIRS+=( $AR_TEMP_DIR )
cd $AR_TEMP_DIR
`ar x $DETECTED_STATIC_LIBRARY`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scchan This line is causing errors. Caused when $DETECTED_STATIC_LIBRARY is from a relative path.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see an error about libmcwamp.a when building the compiler, this patch #9 will fix that

scchan added a commit that referenced this pull request Apr 4, 2016
@scchan
Merge pull request #2 from RadeonOpenCompute/master
e91562d 
merge from upstream
@scchan scchan mentioned this pull request Jun 3, 2016
Closed
@jvesely jvesely mentioned this pull request Feb 25, 2017
Closed
whchung pushed a commit that referenced this pull request Mar 2, 2017
@david-salinas
Merge pull request #2 from RadeonOpenCompute/clang_tot_upgrade
7d505c9 
Update from original
scchan pushed a commit that referenced this pull request Jun 27, 2017
@aaronenyeshi
Merge pull request #2 from RadeonOpenCompute/clang_tot_upgrade
5e9b74d 
Merge to fb80207
@gonuco gonuco mentioned this pull request Sep 1, 2017
Closed
@sriharikarnam sriharikarnam mentioned this pull request Dec 18, 2017
Closed
@nonpolarity nonpolarity mentioned this pull request Jun 13, 2019
Open
@ekuznetsov139 ekuznetsov139 mentioned this pull request Aug 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@whchung whchung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scchan @whchung