Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GridLaunch] Fix an issue where passing a NULL accelerator_view would crash GridLaunch #20

Merged
merged 2 commits into from
Apr 12, 2016
Merged

[GridLaunch] Fix an issue where passing a NULL accelerator_view would crash GridLaunch #20

merged 2 commits into from
Apr 12, 2016

Conversation

kwu91
Copy link
Contributor

@kwu91 kwu91 commented Apr 11, 2016

Tests:

ROCK: dev/5f38f1e4
ROCR: dev/0b9d0e1

********************
Testing Time: 625.28s
********************
Failing Tests (2):
    CPPAMP :: Unit/HC/wg_size.cpp
    CPPAMP :: Unit/HSAIL/shfl_xor.cpp

  Expected Passes    : 657
  Expected Failures  : 25
  Unsupported Tests  : 10
  Unexpected Failures: 2

HIP-privatestaging: privatestaging/31dc13d
HIP-Examples-privatestaging: privatestaging/23c7882

HIP all passed.

@kwu91
[GridLaunch test] Add test where the accelerator_view in grid_launch_…
6c61e93 
…parm is set to NULL

Although in the default constructor, the av pointer in grid_launch_parm struct is
initialized to the default accelerator view, the user may still be free
to modifiy the pointer. This test checks the case if the pointer is set
to NULL.
@kwu91
[GridLaunch] Fix an issue where passing a NULL accelerator_view would…
9621267 
… crash GridLaunch
@whchung whchung merged commit 0bb9515 into ROCm:master Apr 12, 2016
@whchung whchung mentioned this pull request Apr 14, 2016
Closed
@scchan scchan mentioned this pull request Jun 3, 2016
Closed
@jvesely jvesely mentioned this pull request Feb 25, 2017
Closed
@gonuco gonuco mentioned this pull request Sep 1, 2017
Closed
@nonpolarity nonpolarity mentioned this pull request Jun 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwu91 @whchung