gpu static link - handle multiple entries of the same static library #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple time on the command line
| LIB_SEARCH_PATHS+=( ${ARG:2} ) | ||
| else | ||
| LIB_SEARCH_PATHS+=( $PWD"/"${ARG:2} ) | ||
| REAL_PATH=$(realpath ${ARG:2}) |
There was a problem hiding this comment.
realpath is installed on Ubuntu by default. To prevent yet another external dependency, could we try get the canonical path via:
REAL_PATH=$(readlink -f ${ARG:2})
|
replaced realpath with readlink... |
scchan
added a commit
that referenced
this pull request
Apr 4, 2016
[Driver] disable new linker algorithm to prevent some HC application …
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpu static link: handle the case where the same library was specified multiple time on the command line