HCC RT Header needs to trigger re-build #358
Conversation
Merge to recent 844cf36
SWDEV-123229 - HCC RT header changes don't trigger a re-build. When calling "make" to rebuild hcc after modifying the HCC RT headers, the build is not able to detect the change and to rebuild the .cpp files that include the headers being modified. As a result, developers may be getting an hcc built from stale objects.
|
I have tested this on unit tests, and there are no new testcase failures with this. With this fix, developers can modify headers such as kalmar_runtime.h and run make which will be triggered from header file changes. Please let me know if I should also make this change for files include/coordinate, include/array_view, and subdirectory include/experimental/. |
|
@aaronenyeshi thanks for this PR! please help amend it for other headers within |
include/CMakeLists.txt
Outdated
| hc_norm_unorm.inl | ||
| hc_short_vector.inl | ||
| kalmar_short_vectors.inl) | ||
|
|
There was a problem hiding this comment.
is there a way to automatically generate these lists instead of constructing them manually?
There was a problem hiding this comment.
I will take a look
Generate the dependency without having to specify each header files explicitly.
I've added the other header files in the include sub-directories. I've also created a target specific for pstl-headers.
|
Okay, I've made it generate lists automatically for the header files. These commits does not produce any new testcase failures. Please take a look. Thanks! |
|
looks like the build failed to generate the .deb package. |
Fix Jenkin build errors. Seems it dropped the impl/ sub-directory name in cmake_install.cmake.
|
@scchan Yes, I was able to find the bug, and fix it. Seems it dropped the sub-directory impl/ string in the cmake-install.cmake built file. |
include/CMakeLists.txt
Outdated
| # Create target for hcc-headers and set dependencies | ||
| add_custom_target(hcc-headers ALL DEPENDS ${out_files}) | ||
| add_dependencies(world hcc-headers) | ||
| set_target_properties(hcc-headers PROPERTIES FOLDER "HCC Misc") |
There was a problem hiding this comment.
This line (35) might not be useful, as its meant for MS Visual Studio UI navigation. Should I remove it?
There was a problem hiding this comment.
@aaronenyeshi thanks for spotting this. let's remove it for now.
There was a problem hiding this comment.
Great! I think it is ready to be merged.
Not using Visual Studio UI Navigation here.
This resolves JIRA Ticket SWDEV-123229 - HCC RT header changes don't trigger a re-build.
There was an issue with HCC RT Headers not triggering a re-build when running make. This was due to dependencies not being properly set and checked for headers in hcc/include.