Cleanup wrapper IR functions #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new workitem intrinsics + range metadata, correct some attributes on functions, and canonicalize. Correct range metadata to be maximum theoretical workgroup size. Change-Id: I9dedbe2dd62753858ccd0eb7841e228873a2c031
|
@arsenm could you alter this pull request so it goes to "develop" branch? We are moving to a branching strategy more aligned with HIP, where all the latest stuffs go to "develop" first. |
|
Maybe the default github branch should be changed? |
|
master should still be the default branch because that's where users fetch production-ready commits. GitHub UI is less favorable than Bitbucket here because you can't create a new topic branch along with a pull request. I'll create a CONTRIBUTE.md to explain the rules better. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new workitem intrinsics + range metadata, correct
some attributes on functions, and canonicalize.
Correct range metadata to be maximum theoretical workgroup size.
Change-Id: I9dedbe2dd62753858ccd0eb7841e228873a2c031