Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GridLaunch custom serializer #46

Merged
merged 4 commits into from
Apr 30, 2016
Merged

Move GridLaunch custom serializer #46

merged 4 commits into from
Apr 30, 2016

Conversation

kwu91
Copy link
Contributor

@kwu91 kwu91 commented Apr 30, 2016

This PR moved the grid_launch_parm custom serializer to a separate header file, grid_launch.hpp. A subclass called grid_launch_parm_cxx will contain the custom serializer. This header file, grid_launch.hpp is only used in the generated Wrapper file. The Wrapper file is changed to pass in the new class, grid_launch_parm_cxx to the functor. Running the benchmark with the new changes does not show a decrease in performance.

ROCK: dev/b0b2dee
ROCR: dev/de0d9b5

********************
Testing Time: 622.25s
********************
Failing Tests (4):
    CPPAMP :: Unit/HC/memcpy_symbol1.cpp
    CPPAMP :: Unit/HC/memcpy_symbol3.cpp
    CPPAMP :: Unit/HC/wg_size.cpp
    CPPAMP :: Unit/HSAIL/shfl_xor.cpp

  Expected Passes    : 664
  Expected Failures  : 25
  Unsupported Tests  : 10
  Unexpected Failures: 4

HIP-privatestaging: privatestaging/23c7882
HIP-Examples-privatestaging: privatestaging/23c7882

HIP Examples all passed.

HIP tests 2/35 failed:

15/35 Test #15: hipMemcpyAll.tst .......................***Failed  Required regular expression not found.Regex=[PASSED
23/35 Test #24: hipHostRegister.tst ....................***Exception: Other  0.10 sec

…when generating the Wrapper

The serializer code is contained in the grid_launch_parm_cxx subclass,
which is only used in the Wrapper. The subclass does not introduce any
new data members and no virtual functions are used. Because the subclass
is passed into the functor, the compiler will be able to utilize the
custom serializer.
@whchung whchung merged commit 0d07377 into ROCm:improve_grid_launch Apr 30, 2016
@jvesely jvesely mentioned this pull request Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants