clamp-hsatools: Use lld as the liner for AMDGPU #51
Conversation
|
@tstellarAMD could you help revise the pull request so this goes to "develop" branch? |
|
These needs to go in the master branch, otherwise we will break master when llvm updates to code object v2. |
|
@tstellarAMD We are changing to a new branching strategy now. Every new feature goes to develop first. Periodically we'll promote production-ready features to master. |
|
Would it be possible to merge it into both branches? If we only merge it into develop, then master won't work at all with lightning, which would defeat the purpose of having a stable master branch. I think this commit is a special case, because it changes the interface between hcc and lightning. I don't think we are going to have many commits like this. |
|
Ok, let me reopen this pull request. Please give me a signal when it's good to me merged into master. I can then cherry-pick it to develop. |
|
This can be merged now. I'm going to push the LLVM changes in a few minutes. |
|
@tstellarAMD are those changes in LLVM side take place in LLVM trunk? could you let me know the commit # so I'm sure my env is up to speed? |
|
It was committed as svn revision r268647. |
|
@tstellarAMD In terms of git commit, that's: |
We need to wait until co-v2 support lands in LLVM before merging this.