Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various fixes for shfl unit tests, added __wavesize for lc #56

Merged
merged 7 commits into from
May 6, 2016

Conversation

scchan
Copy link
Collaborator

@scchan scchan commented May 6, 2016

  • added __lane_id() and changed a few unit tests to use lane_id
  • added __wavesize() for LC
  • fixed shfl_xor on hsail

Testing Time: 193.42s


Failing Tests (24):
CPPAMP :: Unit/AmpMath/amp_math_erf_precise_math.cpp
CPPAMP :: Unit/AmpMath/amp_math_erfc_precise_math.cpp
CPPAMP :: Unit/AmpMath/amp_math_hypot_precise_math.cpp
CPPAMP :: Unit/AmpShortVectors/hc_short_vector_device.cpp
CPPAMP :: Unit/DynamicTileStatic/test11.cpp
CPPAMP :: Unit/DynamicTileStatic/test12.cpp
CPPAMP :: Unit/DynamicTileStatic/test13.cpp
CPPAMP :: Unit/DynamicTileStatic/test6.cpp
CPPAMP :: Unit/GridLaunch/linkobj.cpp
CPPAMP :: Unit/HC/get_group_segment_sizes.cpp
CPPAMP :: Unit/HC/memcpy_symbol1.cpp
CPPAMP :: Unit/HC/memcpy_symbol2.cpp
CPPAMP :: Unit/HC/memcpy_symbol3.cpp
CPPAMP :: Unit/HC/memcpy_symbol4.cpp
CPPAMP :: Unit/HSAIL/activelaneid.cpp
CPPAMP :: Unit/HSAIL/activelanepermute.cpp
CPPAMP :: Unit/ParallelSTL/sort_carray.cpp
CPPAMP :: Unit/ParallelSTL/sort_stdarray.cpp
CPPAMP :: Unit/ParallelSTL/sort_stdvector.cpp
CPPAMP :: Unit/ParallelSTL/stablesort_carray.cpp
CPPAMP :: Unit/ParallelSTL/stablesort_stdarray.cpp
CPPAMP :: Unit/ParallelSTL/stablesort_stdvector.cpp
CPPAMP :: Unit/SharedLibrary/shared_library2.cpp
CPPAMP :: Unit/SharedLibrary/shared_library3.cpp

Expected Passes : 647
Expected Failures : 25
Unsupported Tests : 10
Unexpected Failures: 24

HSAIL:

scchan/hcc@fd88c90d25ed:~/code/github/radeonopencompute/hcc.develop/build.hsail$ make test
[100%] Running HCC regression tests
llvm-lit: lit.cfg:115: note: using clang: '/home/scchan/code/github/radeonopencompute/hcc.develop/build.hsail/compiler/bin/clang'
Testing Time: 135.46s
Expected Passes : 671
Expected Failures : 25
Unsupported Tests : 10
[100%] Built target test

@whchung
Copy link
Collaborator

whchung commented May 6, 2016

@scchan If I understand your message correctly. There are 24 failure with LC, and 0 with HSAIL, right?

@scchan
Copy link
Collaborator Author

scchan commented May 6, 2016

there were no failure on hsail

I turned off activelaneid and activelanepermute for now.

test results on lc:


Testing Time: 162.44s


Failing Tests (4):
CPPAMP :: Unit/AmpMath/amp_math_erf_precise_math.cpp
CPPAMP :: Unit/AmpMath/amp_math_erfc_precise_math.cpp
CPPAMP :: Unit/AmpMath/amp_math_hypot_precise_math.cpp
CPPAMP :: Unit/AmpShortVectors/hc_short_vector_device.cpp

Expected Passes : 337
Expected Failures : 14
Unsupported Tests : 351
Unexpected Failures: 4
make[3]: *** [tests/CMakeFiles/test] Error 1
make[2]: *** [tests/CMakeFiles/test.dir/all] Error 2
make[1]: *** [tests/CMakeFiles/test.dir/rule] Error 2
make: *** [test] Error 2

@whchung whchung merged commit af0d3b6 into master May 6, 2016
@scchan scchan deleted the lane_id branch May 6, 2016 01:16
@@ -1,4 +1,4 @@
// XFAIL: Linux
// XFAIL: *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would make this test fail even on HSAIL backend. it's better to use hcc_backend macro to check. I'll fix it. the same goes to activelanepermute right below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants