Replace memory region API with memory pool API #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commented code No definition of HSA_AMD_MEMORY_POOL_INFO_ALLOC_MAX_SIZE
- add call to allow_access on am_alloc with amHostPinned flag - remove call to hsa_memory_register and hsa_memory_deregister, those are noop for AMD - move initialization to am_host_memory_pool and am_memory_pool on HSADevice constructor - remove unnecessary check for system memory accessibility because system memory is always accessible via call to hsa_amd_memory_pool_allow_access. - discover system memory region from host agent instead of gpu agent,
Memory pool
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.