Develop stream 2025-01-20 #455

NB4444 · 2025-01-20T14:32:01Z

Develop stream 2025-01-20 changes, needs rocprim stream updates:

Adopt symbol visibility rules in hipCUB

CCCL/thrust 2.6.0 compatibility changes

General CCCL/thrust 2.6.0 changes
Add UnrolledThreadLoad and UnrolledThreadCopy functions

Documentation

Fix warnings when generating sphinx docs
Remove extra dashes in the documentation its \param and \tparam
Update documentation generation instructions

General changes and bug fixes

Add hipGraph capture tests for device run length encode
Test output locations for large indices
fix GenerateResourceSpec for gfx90a
style: add include-what-you-use pragmas to hipcub
log more information during configure
Make HIPCUB_HOST API also accessible on device in single_pass_scan_operators.hpp
Fix compile error in hipCUB with lookback_scan_prefix_flag name change in rocprim
Update thread_store and thread_load for parity.
Some internal changes to the CI

spolifroni-amd

The changelog needs some clarification and changes. I've made some suggestions.

CHANGELOG.md

spolifroni-amd · 2025-01-21T15:31:39Z

CHANGELOG.md

+
+### Known issues
+
+* The deprecated `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails` are not present in CCCL (CUB) from release 2.6.0 on, and thus neither they are in hipCUB's CUB backend for versions strictly greater than 3.4.0. These will be definitely removed from both backends in a future release.


This should be under "Removed" rather than Known Issues

Suggested change

* The deprecated `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails` are not present in CCCL (CUB) from release 2.6.0 on, and thus neither they are in hipCUB's CUB backend for versions strictly greater than 3.4.0. These will be definitely removed from both backends in a future release.

*`BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails`, and `BlockAdjacentDifference::FlagHeadsAndTails` have been deprecated. They were removed in CCCL (CUB) 2.6.0 and have been removed in all versions of hipCUB's CUB backend later than 3.4.0.

When you say "strictly greater than 3.4.0" do you mean from 3.4.1 and on, or do you mean something like 3.4.0.1 and on?

Also I'm confused by this line: "These will be definitely removed from both backends in a future release."

Have they been removed or not? Or do you mean they'll be removed from a different backend in a future release? If they will be removed from a different backend in a future release, that info should be added to the "Upcoming Changes" section.

When you say "strictly greater than 3.4.0" do you mean from 3.4.1 and on, or do you mean something like 3.4.0.1 and on?

AFAIK we only do mayor.minor.patch kind of releases, hence it's meant to be from 3.4.1 on. However, even if a version such as 3.4.0.1 is possible, the update to CCCL 2.6.0 has been done after the 3.4.0 release of hipCUB, so regardless of the next version number the dependency on CCCL 2.6.0 will be there and hence the absence of these functions in the CUB backend of hipCUB.

Also I'm confused by this line: "These will be definitely removed from both backends in a future release."

Have they been removed or not? Or do you mean they'll be removed from a different backend in a future release?

They have been removed from CCCL/CUB (and thus from the CUB backend of hipCUB) as mentioned. However, as discussed internally, these should not be removed from the rocPRIM backend until the next ROCm mayor release so what the sentence means is that these will be dropped from the rocPRIM backend as well in some future release when the next ROCm mayor version is released.

If they will be removed from a different backend in a future release, that info should be added to the "Upcoming Changes" section.

I see, we'll do this!

Oh and also, regarding the suggested changes:

*BlockAdjacentDifference::FlagHeads, BlockAdjacentDifference::FlagTails, and BlockAdjacentDifference::FlagHeadsAndTails have been deprecated.

These were already deprecated, so I think the original sentence should be ok. Perhaps something like:

* The already-deprecated `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails` ...

would make it more clear?

In which version were they deprecated? That could make it clearer. Something like "[functions] that were deprecated in [version] have now been removed"

How does this sound (with the right version put in instead of VERSION_X obvs :) ):

* `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails` have been removed from hipCUB's CUB backend as of version 3.4.1. They were already removed from CCCL (CUB) as of version 2.6.0 and deprecated in VERSION_X of hipCUB's CUB backend.

That sounds good! My final suggestion after some re-writting to clarify which version is hipCUB's and which is CCCL's:

### Known issues * `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails` have been removed from hipCUB's CUB backend. They were already deprecated as of version 2.12.0 of hipCUB and they were removed from CCCL (CUB) as of CCCL's 2.6.0 release. ... ### Upcoming Changes * `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails`, already deprecated as of version 2.12.0 of hipCUB, will be removed from the rocPRIM backend in a future release for the next ROCm major version (ROCm 7.0.0).

I'd smooth it a bit, but otherwise I'm good with this! Clarity is very appreciated! :)

BlockAdjacentDifference::FlagHeads, BlockAdjacentDifference::FlagTails and BlockAdjacentDifference::FlagHeadsAndTails were deprecated as of version 2.12.0 of hipCUB, and will be removed from the rocPRIM backend in a future release for the next ROCm major version (ROCm 7.0.0).

I'm gonna approve so you don't have to wait for me.

spolifroni-amd

One last thing :)

hipcub/include/hipcub/device/device_merge_sort.hpp

…t verify output locations"

…s_scan_operators.hpp"

NB4444 · 2025-02-21T07:14:18Z

Resolved some merge conflicts.

umfranzw

Looks good to me.

NB4444 changed the title ~~Develop upstream 2025 01 20~~ Develop stream 2025 01 20 Jan 20, 2025

NB4444 changed the title ~~Develop stream 2025 01 20~~ Develop stream 2025-01-20 Jan 20, 2025

NB4444 marked this pull request as ready for review January 21, 2025 12:35

NB4444 requested review from a team, stanleytsang-amd, umfranzw, RobsonRLemos and lawruble13 as code owners January 21, 2025 12:35

spolifroni-amd requested changes Jan 21, 2025

View reviewed changes

NB4444 force-pushed the develop_upstream_2025_01_20 branch from c77a7b4 to 1a7cf6c Compare January 23, 2025 09:10

spolifroni-amd requested changes Jan 23, 2025

View reviewed changes

Beanavil force-pushed the develop_upstream_2025_01_20 branch from 5d84fef to d7b76ca Compare January 28, 2025 11:03

spolifroni-amd approved these changes Jan 28, 2025

View reviewed changes

Beanavil force-pushed the develop_upstream_2025_01_20 branch from d7b76ca to f2071b1 Compare January 29, 2025 11:59

umfranzw reviewed Feb 20, 2025

View reviewed changes

hipcub/include/hipcub/device/device_merge_sort.hpp Outdated Show resolved Hide resolved

Beanavil and others added 15 commits February 21, 2025 07:07

Add hipGraph capture tests for device run length encode

7daaf00

Resolve "test_device_adjacent_difference.cpp: Large indices test don'…

d50f6a6

…t verify output locations"

fix GenerateResourceSpec for gfx90a

74e798b

style: add include-what-you-use pragmas to hipcub

66e199e

Fix warnings when generating sphinx docs

2a6fd07

Update documentation generation instructions

facfce3

CI changes to speedup development

0751276

log more information during configure

4081322

Fix rules overwrite for other then MR pipelines

667dd02

Windows CI

3ae68a9

Fix test:rocm_install and test:rocm_package on rocm/dev-ubuntu

90d75d5

Resolve "General changes CCCL 2.6"

8bc8a1e

Resolve "Make HIPCUB_HOST API also accessible on device in single_pas…

2e57fdb

…s_scan_operators.hpp"

Remove extra dashes in the documentation its \param and \tparam

d58d4e5

Resolve "Add UnrolledThreadLoad and UnrolledThreadCopy functions"

83752d6

cenxuantian and others added 9 commits February 21, 2025 07:10

Resolve "Fix compile error in hipCUB"

453a63b

Update new tests with new graph utils

8645830

Adopt symbol visibility rules in hipCUB

911097e

Resolve "Update thread_store for parity"

83de375

Update copyright dates

b90c0f2

CHANGELOG changes based on review

4170c7d

doc: add upcoming changes entry for BlockAdjacentDifference APIs removal

f582893

Add symbol visibility feedback changes to CHANGELOG

1efc938

Remove double comment

986a1fb

NB4444 force-pushed the develop_upstream_2025_01_20 branch from 67c4136 to 986a1fb Compare February 21, 2025 07:12

umfranzw approved these changes Feb 28, 2025

View reviewed changes

stanleytsang-amd merged commit d0c39fc into ROCm:develop Feb 28, 2025
6 of 13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop stream 2025-01-20 #455

Develop stream 2025-01-20 #455

NB4444 commented Jan 20, 2025 •

edited

Loading

spolifroni-amd left a comment

spolifroni-amd Jan 21, 2025

Beanavil Jan 23, 2025 •

edited

Loading

Beanavil Jan 23, 2025

spolifroni-amd Jan 23, 2025

spolifroni-amd Jan 23, 2025

Beanavil Jan 28, 2025

spolifroni-amd Jan 28, 2025

spolifroni-amd Jan 28, 2025

Beanavil Jan 29, 2025

spolifroni-amd left a comment

NB4444 commented Feb 21, 2025

umfranzw left a comment


		### Known issues

		* The deprecated `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails` are not present in CCCL (CUB) from release 2.6.0 on, and thus neither they are in hipCUB's CUB backend for versions strictly greater than 3.4.0. These will be definitely removed from both backends in a future release.

	* The deprecated `BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails` and `BlockAdjacentDifference::FlagHeadsAndTails` are not present in CCCL (CUB) from release 2.6.0 on, and thus neither they are in hipCUB's CUB backend for versions strictly greater than 3.4.0. These will be definitely removed from both backends in a future release.
	*`BlockAdjacentDifference::FlagHeads`, `BlockAdjacentDifference::FlagTails`, and `BlockAdjacentDifference::FlagHeadsAndTails` have been deprecated. They were removed in CCCL (CUB) 2.6.0 and have been removed in all versions of hipCUB's CUB backend later than 3.4.0.

Develop stream 2025-01-20 #455

Develop stream 2025-01-20 #455

Conversation

NB4444 commented Jan 20, 2025 • edited Loading

spolifroni-amd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Beanavil Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spolifroni-amd left a comment

Choose a reason for hiding this comment

NB4444 commented Feb 21, 2025

umfranzw left a comment

Choose a reason for hiding this comment

NB4444 commented Jan 20, 2025 •

edited

Loading

Beanavil Jan 23, 2025 •

edited

Loading