Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gfx940 / gfx941 code #459

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

umfranzw
Copy link
Collaborator

@umfranzw umfranzw commented Feb 7, 2025

Moving forward we will no longer support custom builds for gfx940 and gfx941. This change removes code that references those architectures.

@umfranzw umfranzw requested a review from NguyenNhuDi February 7, 2025 15:27
@umfranzw umfranzw changed the base branch from develop to release-staging/rocm-rel-6.4 February 11, 2025 21:19
@umfranzw umfranzw requested a review from a team as a code owner February 11, 2025 21:19
@umfranzw umfranzw changed the base branch from release-staging/rocm-rel-6.4 to develop February 11, 2025 21:36
Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing to review for docs, but do these changes need to be reflected in the docs (supported systems) or in the changelog?

Moving forward we will no longer support custom
builds for gfx940 and gfx941. This change removes
code that references those architectures.
@umfranzw
Copy link
Collaborator Author

There's nothing to review for docs, but do these changes need to be reflected in the docs (supported systems) or in the changelog?

Thanks, good idea. I've added a note to the changelog.

@umfranzw
Copy link
Collaborator Author

I've resolved the merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants