-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "cmake: use HIP CONFIG on Windows"
This reverts commit 41491c9. By the cmake documentation, Do not write find modules for packages that themselves build with CMake. Instead provide a CMake package configuration file with the package itself. HIP uses cmake to build. It should not have shipped a FindHIP.cmake (a cmake MODULE). A hip-config.cmake (a cmake CONFIG) is enough. We should use CONFIG on both Windows and GNU/Linux. Thus the commit needs to be reverted. Reference: https://cmake.org/cmake/help/latest/command/find_package.html Signed-off-by: Benda Xu <heroxbd@gentoo.org>
- Loading branch information
Benda Xu
committed
Jul 29, 2023
1 parent
a3168b5
commit 6537a04
Showing
4 changed files
with
5 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters