Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TENSILE_ENABLE_MARKER and HIPSPARSELT_ENABLE_MARKER #181

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tsenwang
Copy link

@tsenwang tsenwang commented Dec 16, 2024

Enable roctx marker

  • When building hipsparselt library through instaill.sh, use option enable_hipsparselt_marker and enable_tensile_marker to enable marker feature.
  • At runtime, use env variable: HIPSPARSELT_ENABLE_MARKER=1 and TENSILE_ENABLE_MARKER=1 to enable marker.

@tsenwang tsenwang force-pushed the develop branch 4 times, most recently from 943a040 to 66b02c9 Compare December 31, 2024 07:26
@vin-huang vin-huang added the gfx94x Run CI on gfx94x label Jan 2, 2025
@@ -329,6 +329,8 @@ tensile_version=
build_tensile=true
tensile_msgpack_backend=true
build_dir_user=build
enable_hipsparselt_marker=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add the description at display_help() for both these two options.

#ifndef HIPSPARSELT_ENABLE_MARKER
if(m_printMarker)
{
printf("HIPSPARSELT_ENABLE_MARKER is not defined. Please rebuild with -DHIPSPARSELT_ENABLE_MARKER=ON\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please try to use hipsparselt_cerr instead.

@tsenwang tsenwang force-pushed the develop branch 5 times, most recently from a996ce0 to 8ac6ea2 Compare January 9, 2025 07:46
- Added support for enabling markers in the hipsparselt library.
- To enable markers during build, use the following options in install.sh:
  --enable-hipsparselt-marker
  --enable-tensile-marker
- At runtime, markers can be enabled by setting the following environment variables:
  HIPSPARSELT_ENABLE_MARKER=1
  TENSILE_ENABLE_MARKER=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gfx94x Run CI on gfx94x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants