Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Permutation with CK #150

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Implement Permutation with CK #150

merged 5 commits into from
Nov 21, 2023

Conversation

CongMa13
Copy link
Collaborator

@CongMa13 CongMa13 commented Nov 7, 2023

No description provided.

@CongMa13 CongMa13 force-pushed the permute_test branch 2 times, most recently from 3188d4b to bcedba6 Compare November 8, 2023 01:56
@CongMa13
Add CPU implementation of elementwise permutation
074c000 
- Add CPU implementation of elementwise permutation -  permutationByCpu
- Add sample of elementwise permutation

GPU implementation of elementwise permutation is not done yet.
@CongMa13
Move files used by all tests out of 01_contraction
60f4b90 
moved 01_contraction/device/common.hpp -> device/common.hpp
renamed 01_contraction/common.hpp -> utils.hpp since there is already a
file named common.hpp in test folder
@CongMa13
Implement permutation with CK
bf1c7ee 
- implemented `hiptensorPermutation` with CK
- added unit tests for `hiptensorPermutation`
@CongMa13 CongMa13 marked this pull request as ready for review November 13, 2023 22:01
cgmillette
cgmillette reviewed Nov 14, 2023
View reviewed changes
test/utils.hpp Outdated Show resolved Hide resolved
cgmillette
cgmillette reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to think about how to treat the __half datatype.
At some level we will have to wrap __half as _Float16 as they follow the same IEEE format.

@cgmillette
Copy link
Collaborator

@CongMa13 we should coordinate with CI about updating the CK package so that pre-checkin should pass

@CongMa13
Support both row_major and col_major data layout
082a966 
Data layout of cuTenor is col_major by default. HipTensor contraction
only supports row_major for now. HipTensor supports both col_major
and row_major to make users be able to choose which layout they want to
use.

- Use CMake option `HIPTENSOR_DATA_LAYOUT_COL_MAJOR` to choose layout
cgmillette
cgmillette previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CongMa13
Add type related files
53d863a 
new file:   include/native_types.hpp
new file:   include/native_types_impl.hpp
new file:   include/type_traits.hpp
new file:   include/types_ext.hpp
new file:   include/xfloat32.hpp
@CongMa13 CongMa13 merged commit ae13ca0 into ROCm:develop Nov 21, 2023
1 of 2 checks passed
@CongMa13 CongMa13 deleted the permute_test branch May 3, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgmillette cgmillette cgmillette approved these changes

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@mkarunan mkarunan Awaiting requested review from mkarunan

@dlangbe dlangbe Awaiting requested review from dlangbe dlangbe is a code owner

@afanfa afanfa Awaiting requested review from afanfa afanfa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CongMa13 @cgmillette