Add mode test #215
Merged
Add mode test #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CongMa13
requested review from
cgmillette,
bragadeesh,
mkarunan,
dlangbe and
afanfa
as code owners
cgmillette
reviewed
Apr 24, 2024
cgmillette
previously approved these changes
Apr 24, 2024
…e test
- Remove elementSpaceFromLengthsAndStrides()
elementSpaceFromLengthsAndStrides has the same feature as
elementsFromLengths
- Test modes of input and output tensor in random orders
It does not affect the feature to set the padding stride to 1. But it is easier to understand the algorithm to set the padding stride to the previous valid strid.
CongMa13
force-pushed
the
fix_yaml
branch
2 times, most recently
from
194e42e to
2a0ee73
Compare
cgmillette
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for any modes of tensors
For example, modes could be
One change to support the mode unit test is sequence test parameters.
Combined test parameter is the only type supported before. But in mode test we cannot combine lengths with modes.
for example, length [1, 2], [1, 2, 3] cannot combine with modes [0, 1], [0, 1, 2]
So added support to sequence test parameters.
Example: test.yaml
The test params are