Skip to content

Commit 30db483

Browse files
authored
Merge pull request #128 from ROCm-Developer-Tools/promotion/mainline/2023.08.02
Promote develop branch (as of a118509) to mainline
2 parents 7f972b9 + 82185b3 commit 30db483

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

amd/hipcc/bin/hipcc.pl

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ sub get_normalized_path {
230230
my $hasOMPTargets = 0; # If OMP targets is mentioned
231231
my $hasC = 0; # options contain a c-style file
232232
my $hasCXX = 0; # options contain a cpp-style file (NVCC must force recognition as GPU file)
233-
my $hasCU = 0; # options contain a cu-style file (HCC must force recognition as GPU file)
234233
my $hasHIP = 0; # options contain a hip-style file (HIP-Clang must pass offloading options)
235234
my $printHipVersion = 0; # print HIP version
236235
my $printCXXFlags = 0; # print HIPCXXFLAGS
@@ -441,6 +440,9 @@ sub get_normalized_path {
441440
$needCXXFLAGS = 1;
442441
if ($HIP_COMPILE_CXX_AS_HIP eq '0' or $HIP_PLATFORM ne "amd" or $hasOMPTargets eq 1) {
443442
$hasCXX = 1;
443+
if ($HIP_PLATFORM eq "nvidia") {
444+
$toolArgs .= " -x cu";
445+
}
444446
} elsif ($HIP_PLATFORM eq "amd") {
445447
$hasHIP = 1;
446448
$toolArgs .= " -x hip";
@@ -450,8 +452,8 @@ sub get_normalized_path {
450452
if ($HIP_PLATFORM eq "amd") {
451453
$hasHIP = 1;
452454
$toolArgs .= " -x hip";
453-
} else {
454-
$hasCU = 1;
455+
} elsif ($HIP_PLATFORM eq "nvidia") {
456+
$toolArgs .= " -x cu";
455457
}
456458
}
457459
}
@@ -532,10 +534,6 @@ sub get_normalized_path {
532534
$ENV{HCC_EXTRA_LIBRARIES}="\n";
533535
}
534536

535-
if ($hasCXX and $HIP_PLATFORM eq 'nvidia') {
536-
$HIPCXXFLAGS .= " -x cu";
537-
}
538-
539537
if ($buildDeps and $HIP_PLATFORM eq 'nvidia') {
540538
$HIPCXXFLAGS .= " -M -D__CUDACC__";
541539
$HIPCFLAGS .= " -M -D__CUDACC__";
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
rocm-docs-core==0.19.0
1+
rocm-docs-core==0.20.0

amd/hipcc/docs/.sphinx/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ requests==2.28.2
9292
# via
9393
# pygithub
9494
# sphinx
95-
rocm-docs-core==0.19.0
95+
rocm-docs-core==0.20.0
9696
# via -r requirements.in
9797
smmap==5.0.0
9898
# via gitdb

0 commit comments

Comments
 (0)