Skip to content

Commit

Permalink
[AMD][HIPCC] Set function support to 1 by default
Browse files Browse the repository at this point in the history
Change-Id: I42e6fffdc7ee69091af0dea6a97c9b45f53fd0e6
  • Loading branch information
shiltian committed Mar 11, 2024
1 parent a23074a commit feba9fa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions amd/hipcc/bin/hipcc.pl
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ sub get_normalized_path {
$HIPLDFLAGS .= " --ld-path=" . get_normalized_path("$HIP_CLANG_PATH/lld-link.exe");
}

# get Clang RT Builtin path
# get Clang RT Builtin path
$HIP_CLANG_RT_LIB = `$HIPCC --print-runtime-dir`;
chomp($HIP_CLANG_RT_LIB);

Expand Down Expand Up @@ -212,7 +212,7 @@ sub get_normalized_path {
my $runCmd = 1;
my $buildDeps = 0;
my $hsacoVersion = 0;
my $funcSupp = 0; # enable function support
my $funcSupp = 1; # enable function support
my $rdc = 0; # whether -fgpu-rdc is on

my @options = ();
Expand Down
4 changes: 2 additions & 2 deletions amd/hipcc/src/hipBin_amd.h
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ void HipBinAmd::executeHipCCCmd(vector<string> argv) {
bool runCmd = 1;
bool buildDeps = 0;
string hsacoVersion;
bool funcSupp = 0; // enable function support
bool funcSupp = 1; // enable function support
bool rdc = 0; // whether -fgpu-rdc is on

string prevArg; // previous argument
Expand Down Expand Up @@ -568,7 +568,7 @@ void HipBinAmd::executeHipCCCmd(vector<string> argv) {
if (hipBinUtilPtr_->stringRegexMatch(arg, pattern)) {
if (targetOpt == "--amdgpu-target=") {
std::cerr << "Warning: The --amdgpu-target option has been deprecated and will be removed in the future."
<< " Use --offload-arch instead.\n";
<< " Use --offload-arch instead.\n";
}
// If targets string is not empty,
// add a comma before adding new target option value.
Expand Down

0 comments on commit feba9fa

Please sign in to comment.