[flang][OpenMP] Document do concurent mapping status and next steps
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a doc to document the current status of `do concurent` mapping, its limitation, and potential next steps.
ergawy
requested review from
skatrak,
jsjodin,
abidh,
mjklemm,
raghavendhra,
agozillon,
DominikAdamski,
dpalermo,
TIFitis,
kparzysz,
pbhandar-amd and
bhandarkar-pranav
mjklemm
approved these changes
Jun 12, 2024
skatrak
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Thank you Kareem for writing this document. It helps quite a bit understanding the current handling of do concurrent. We just need to make sure to keep it updated as we make changes to it! I just have a couple of suggestions for changes, but just small things.
|
|
||
| ### More advanced detection of loop nests | ||
|
|
||
| As pointed out earlier, any intervening code between the headers of 2 nested `do concurrent` loops prevents us currently from detecting this as a loop nest. In some cases this is overly conservative. Therefore, a more flexible detection logic of loop nests needs to be implemented. |
There was a problem hiding this comment.
Do you have already any plan in mind to decide where to place the operations that were originally located between the outer and inner loop?
There was a problem hiding this comment.
Nothing concrete yet. Stay tuned 😛.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a doc to document the current status of
do concurentmapping, itslimitation, and potential next steps.
This PR assumes the latest status of #89 is taken into account.