Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR][OpenMP] Prevent not-yet-implemented errors for SIMD #212

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

skatrak
Copy link

@skatrak skatrak commented Nov 25, 2024

This addresses compilation failures related to SIMD clauses by choosing to ignore them instead of emitting not-yet-implemented errors.

This addresses compilation failures related to SIMD clauses by choosing to
ignore them instead of emitting not-yet-implemented errors.
Copy link

@DominikAdamski DominikAdamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ronlieb ronlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go with this short term approach on ATD

@skatrak skatrak merged commit ae842a7 into ROCm:amd-trunk-dev Nov 27, 2024
2 of 4 checks passed
@skatrak skatrak deleted the simd-ignore branch November 27, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants