Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP] [Flang] [MLIR] Allow dist_schedule(static) to be default behavior in OMP DISTRIBUTE directive #220

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

raghavendhra
Copy link

According to the OpenMP spec, the default schedule for distribute is implementation-defined. We effectively implement a static schedule by default, so we simply parse and ignore the dist_schedule clause instead of flagging it as unimplemented error message.

After this change,

!$omp target teams distribute parallel do dist_schedule(static) -> No longer issues unimplemented error message for dist_schedule static only case

!$omp target teams distribute parallel do dist_schedule(static, chunk_size) -> Issues unimplemented error message for dist_schedule chunk_size

Copy link

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@raghavendhra raghavendhra merged commit 16d4aea into amd-trunk-dev Dec 3, 2024
2 of 4 checks passed
@raghavendhra raghavendhra deleted the default_dist_schedule_static branch December 3, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants