Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][AMDGPU] Do not attach -fcuda-is-device (#99002) #234

Closed

Conversation

hidekisaito
Copy link

-fcuda-is-device flag is not used for OpenMP offloading for AMD GPUs and
it does not need to be added as clang cc1 option for OpenMP code.

This PR has the same functionality as
llvm#96909 but it doesn't introduce
regression for virtual function support.

Cherry pick: 14c323c

Change-Id: I3961d7ed0264ef3e921c4ce443bce31f2564f3ec

-fcuda-is-device flag is not used for OpenMP offloading for AMD GPUs and
it does not need to be added as clang cc1 option for OpenMP code.

This PR has the same functionality as
llvm#96909 but it doesn't introduce
regression for virtual function support.

Cherry pick: 14c323c

Change-Id: I3961d7ed0264ef3e921c4ce443bce31f2564f3ec
Copy link
Collaborator

@ronlieb ronlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be on gerrit amd-mainline

@ronlieb
Copy link
Collaborator

ronlieb commented Dec 19, 2024

move to gerrit plz

@ronlieb ronlieb closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants