Skip to content

[Comgr] Fix memory leak in comgr for TranslatedSpirvT #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

[Comgr] Fix memory leak in comgr for TranslatedSpirvT #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions amd/comgr/src/comgr-compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1884,6 +1884,7 @@ amd_comgr_status_t AMDGPUCompiler::compileSpirvToRelocatable() {
amd_comgr_data_set_t TranslatedSpirvT;
if (auto Status = amd_comgr_create_data_set(&TranslatedSpirvT))
return Status;
ScopedDataSetReleaser SDSR(TranslatedSpirvT);
DataSet *TranslatedSpirv = DataSet::convert(TranslatedSpirvT);

if (auto Status = translateSpirvToBitcodeImpl(InSet, TranslatedSpirv))
Expand Down
9 changes: 9 additions & 0 deletions amd/comgr/src/comgr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,15 @@ class ScopedDataObjectReleaser {
~ScopedDataObjectReleaser() { Obj->release(); }
};

class ScopedDataSetReleaser {
amd_comgr_data_set_t Set;

public:
ScopedDataSetReleaser(amd_comgr_data_set_t Set) : Set(Set) {}

~ScopedDataSetReleaser() { amd_comgr_destroy_data_set(Set); }
};

struct DataSet {

DataSet();
Expand Down