Skip to content

Fix crash in getFileIDLocal when ID is negative. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix crash in getFileIDLocal when ID is negative. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clang/lib/Basic/SourceManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,8 +751,7 @@ FileID SourceManager::getFileIDLocal(unsigned SLocOffset) const {

// FIXME: Handle file start location
// It is CXXAMP Specific. However it shall be ok in general
bool patch = (LocalSLocEntryTable[LastFileIDLookup.ID].getOffset() <= SLocOffset);
if (LastFileIDLookup.ID < 0 || patch ||
if (LastFileIDLookup.ID < 0 || (LocalSLocEntryTable[LastFileIDLookup.ID].getOffset() <= SLocOffset) ||
LocalSLocEntryTable[LastFileIDLookup.ID].getOffset() < SLocOffset) {
// Neither loc prunes our search.
I = LocalSLocEntryTable.end();
Expand Down