Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2.x logging #308

Merged
merged 45 commits into from
Mar 11, 2024
Merged

Update 2.x logging #308

merged 45 commits into from
Mar 11, 2024

Commits on Mar 8, 2024

  1. Standalone logging module for cleaner omniperf_base.py 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    32fee2f View commit details
    Browse the repository at this point in the history

  2. Remove outdated remove_workload.py module 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    fd28a9b View commit details
    Browse the repository at this point in the history

  3. Dedicated logging function for each log level 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7bff75e View commit details
    Browse the repository at this point in the history

  4. All logging should use call new functions 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6a51289 View commit details
    Browse the repository at this point in the history

  5. Connect verbosity flag to loglevel 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e735b76 View commit details
    Browse the repository at this point in the history

  6. Replaced some straggling print statements with log functions 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b7f9363 View commit details
    Browse the repository at this point in the history

  7. Resolve merge conflict I missed in prev rebase 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b19eb7b View commit details
    Browse the repository at this point in the history

  8. Fix python formatting 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    386adf2 View commit details
    Browse the repository at this point in the history

  9. Fix dangling merge conflict 

    Signed-off-by: colramos-amd <colramos@amd.com>
    @coleramos425 @koomie
    coleramos425 authored and koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    89e34e4 View commit details
    Browse the repository at this point in the history

  10. tighten-up profile usage examples 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6ba1561 View commit details
    Browse the repository at this point in the history

  11. enable a progress bar for running in profile mode - only enabled when 

    loglevel is set to ERROR

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    996aa57 View commit details
    Browse the repository at this point in the history

  12. update setup_logging function to return loglevel; disable inclusion of 

    loglevel delimiter in output

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    df703fe View commit details
    Browse the repository at this point in the history

  13. assign loglevel attribute in omniperf base class 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c287d34 View commit details
    Browse the repository at this point in the history

  14. include loglevel function argument to "run_prof" routine 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7dbe768 View commit details
    Browse the repository at this point in the history

  15. add indent support to console_log() 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    ebd553a View commit details
    Browse the repository at this point in the history

  16. minor refactor of print_status() 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5ee4544 View commit details
    Browse the repository at this point in the history

  17. add a profileMode option to capture_subprocess_output() - includes 

    indented output with profiler selection when enabled

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    ffadd04 View commit details
    Browse the repository at this point in the history

  18. include ERROR delimiter directly for console_error() messsages 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f1cabf2 View commit details
    Browse the repository at this point in the history

  19. remove duplicate process output within run_prof() 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a0dd58d View commit details
    Browse the repository at this point in the history

  20. updates for run_prof() routine: 

    * add a profileMode keyword option, used to indent profiling output

* update logic if forked process is not successful, output is
  displayed directly with INFO logging or lower; also dispaly output
  in ERROR mode if the process fails

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    deccf37 View commit details
    Browse the repository at this point in the history

  21. add a exit keyword to console_error function; allows multiple error 

    lines prior to code exit

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a94a962 View commit details
    Browse the repository at this point in the history

  22. add quietmode option to setup_logging function 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    900008e View commit details
    Browse the repository at this point in the history

  23. adding --quiet and --verbose options to top-level help info; pass 

    quiet arg to setup_logging function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b739810 View commit details
    Browse the repository at this point in the history

  24. apply formatter 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a57331c View commit details
    Browse the repository at this point in the history

  25. refactor logging initialization into two steps: 

    (1) setup_logging_handler -> called prior to arg parsing
(2) setup_logging_priority -> called after arg parsing

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f189944 View commit details
    Browse the repository at this point in the history

  26. use cached loglevel var in arguments to decide on status bar presence 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f4c4592 View commit details
    Browse the repository at this point in the history

  27. rework of logger.py setup to introduce another setup_file_handler() - 

    this function enables file-based logger output for use with profile
mode

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6c50ebb View commit details
    Browse the repository at this point in the history

  28. update print_status() to use console logger; convert some info logs t… 

    …o debug logs

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c605563 View commit details
    Browse the repository at this point in the history

  29. enable file-logger in profiling workflow; turn some info messages int… 

    …o debug

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    57806a3 View commit details
    Browse the repository at this point in the history

  30. update log summary at begin of profiling mode 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c08bf02 View commit details
    Browse the repository at this point in the history

  31. remove duplicate line after conflict cleanup due to rebase 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    6bcf3e3 View commit details
    Browse the repository at this point in the history

  32. refactor setting of local encoding; remove from top-level omniperf 

    wrapper and push into base class via a companion utility function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3c67670 View commit details
    Browse the repository at this point in the history

  33. apply formatting 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    04c4bb1 View commit details
    Browse the repository at this point in the history

  34. allow color formatter via env variable OMNIPERF_COLOR=1 

    Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    fa2667d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Update src/omniperf_base.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3732ef9 View commit details
    Browse the repository at this point in the history

  2. Update src/omniperf_profile/profiler_base.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    360147b View commit details
    Browse the repository at this point in the history

  3. Update src/utils/utils.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    f2002d1 View commit details
    Browse the repository at this point in the history

  4. Update src/omniperf_profile/profiler_rocscope.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    bbd0b28 View commit details
    Browse the repository at this point in the history

  5. Update src/utils/db_connector.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c760482 View commit details
    Browse the repository at this point in the history

  6. Update src/omniperf_profile/profiler_base.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    64bc39b View commit details
    Browse the repository at this point in the history

  7. Update src/omniperf_profile/profiler_rocscope.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a79e7f4 View commit details
    Browse the repository at this point in the history

  8. Update src/utils/db_connector.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    f4c2aff View commit details
    Browse the repository at this point in the history

  9. Update src/utils/utils.py 

    Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
    @koomie @coleramos425
    koomie and coleramos425 authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    81d3f57 View commit details
    Browse the repository at this point in the history

  10. Merge branch '2.x' into better-logs-koomie

    @koomie
    koomie authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    0d1967b View commit details
    Browse the repository at this point in the history

  11. move set_locale_encoding() to occur after logging is setup - allows 

    function to use console_error() directly (#308 (comment))

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
    @koomie
    koomie committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    add814f View commit details
    Browse the repository at this point in the history