Check Python version on application launch #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
This was breaking the "tarball" workflow. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
commented
Aug 7, 2024
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
peterjunpark
approved these changes
Aug 8, 2024
skyreflectedinmirrors
requested changes
Aug 8, 2024
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Recommend `python3 -m pip <...>` instead, to ensure the version of `pip` used is the same as the version of `python3` that will be use run omniperf. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
that referenced
this pull request
Aug 13, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
lajagapp
pushed a commit
to lajagapp/omniperf
that referenced
this pull request
Aug 14, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
dgaliffiAMD
added a commit
that referenced
this pull request
Aug 19, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
coleramos425
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
coleramos425
pushed a commit
that referenced
this pull request
Sep 27, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 16, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 17, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 19, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 19, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 19, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 19, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RHEL8, Omniperf fails to load after installing via the RPM package, because the default
python3installed is version 3.6.RPM-build changes the "shebang" from
#!/usr/bin/env python3to#!/usr/libexec/platform-python, which interfered with setting virtual environments throughconda.Added an additional dependency check on launch. Just before we check for the PIP dependencies, we will now check the version of python being used. If it is less than 3.8, then output a more readable message, rather than a cryptic import failure that is currently seen.
Add a note to our "install via package manager" section in documentation.
Also, fixed some python linter warnings.
Internal ticket SWDEV-477233.