-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest v2 #297
Open
JoseSantosAMD
wants to merge
14
commits into
ROCm:main
Choose a base branch
from
JoseSantosAMD:pytest-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pytest v2 #297
Commits on Apr 23, 2024
-
- default settings for parser made a global variable for easy importing - create_parser make parser, so that it can be imported and used in pytest - h4 tags removed from plotless gui - pytest waits for h4 tags to appear to commence testing - page.py has functions to get data from histograms, plots, sorting - also has functions to get title data and use slider Move data from file to script - keys, titles, file_names, file_names_recursive now global vars - test_find_causal_files uses those vars - reformatted Expected Values written into script - test_parse_files now has expected vals in script - tests impact, point count, speedup - values are rounded to 4 to avoid floating point errors - Added expected title sets - added file_names to find_causal_files and parse_files - Added expected title sets to alpha_title_order - Added expected title sets to gui_flag tests - Added workload_dir instead of absolute path reformatting Separate test_parse_files by test - each test runs parse_files with a different set of inputs - some expected vals are global bc they are used often and consistent split compute speedups - each test runs compute_speedups with a different set of inputs - removed need for test_results.json - sparse tests for plot data - add expected_title_set for ordering tests - removed experiments/progress_points since it is being tested already Move testing validation from parse_files to compute - Validation now tested with single file and multiple - Added expected title set to min_points_slider test - Remove unused parts of code min points fix - Changed min points to greater than or equal - Redefined point count to num points in line not chart - Some reformatting Slider, single line legend, and upload file fix - Remove unused function - Add using flag min points to slider in header - Add legend for when only chart has only one line - Name reformatting - Gui workload path now uses find_causal_files - Drag and Drop file now has correct workloads Uploaded_file and compute_sorts tests - Add testing for compute_sorts - Add testing for uploaded_file - Remove print statements Put frequently used data as global var - Add json files used for testing - Put frequently used data as global var - Update file names to use os.path Reformatting Remove unused imports/variables remove unused imports New min points bug - Redefining Min points changed test output Linting errors fix - Move imports to the top of file - remove unused vars Linting error fix - Move imports to the top of file Remove extra spaces reformatting Captured Histogram data Now tested
Configuration menu - View commit details
-
Copy full SHA for 9620ad3 - Browse repository at this point
Copy the full SHA 9620ad3View commit details -
Causal GUI test file reorganization
- Relocated /tests to /source/tests - Relocated /workloads to /source/workflows
Configuration menu - View commit details
-
Copy full SHA for c26752b - Browse repository at this point
Copy the full SHA c26752bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a7f92b - Browse repository at this point
Copy the full SHA 1a7f92bView commit details -
- added /pytest.ini with a default setup when running testing
Configuration menu - View commit details
-
Copy full SHA for 24388a2 - Browse repository at this point
Copy the full SHA 24388a2View commit details -
- Suppress 'No matching causal data for expected validations:' message from compute_speedups(...) function unless debug is True
Configuration menu - View commit details
-
Copy full SHA for 536721b - Browse repository at this point
Copy the full SHA 536721bView commit details -
- tweaked imports after relocation - added license to tests/page.py and tests/tesh_graphs.py - fixed test_find_causal_files_valid_directory comparing unsorted data
Configuration menu - View commit details
-
Copy full SHA for 64dd682 - Browse repository at this point
Copy the full SHA 64dd682View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03b9135 - Browse repository at this point
Copy the full SHA 03b9135View commit details -
- fixed some test failures (comparing unsorted lists, etc.) - corrected some reference values in tests - added try/finally in many places to ensure process running GUI is terminated
Configuration menu - View commit details
-
Copy full SHA for 07ab689 - Browse repository at this point
Copy the full SHA 07ab689View commit details -
- use sudo for apt-get since not in docker container - add ~/.local/bin to PATH
Configuration menu - View commit details
-
Copy full SHA for bd3b845 - Browse repository at this point
Copy the full SHA bd3b845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a8c921 - Browse repository at this point
Copy the full SHA 9a8c921View commit details -
Configuration menu - View commit details
-
Copy full SHA for d001f69 - Browse repository at this point
Copy the full SHA d001f69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19ae19a - Browse repository at this point
Copy the full SHA 19ae19aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7687342 - Browse repository at this point
Copy the full SHA 7687342View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7978ee - Browse repository at this point
Copy the full SHA e7978eeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.