Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIGraphX EP] Fix CopyTensorAsync and add guards for stream sync Copy… #15

Open
wants to merge 1 commit into
base: rocm5.7_internal_testing
Choose a base branch
from
Open

[MIGraphX EP] Fix CopyTensorAsync and add guards for stream sync Copy… #15

wants to merge 1 commit into from

Commits on Jul 26, 2023

  1. [MIGraphX EP] Fix CopyTensorAsync and add guards for stream sync Copy… 

    …Tensors (microsoft#16787)

Add compile guards to gate functionality based on MIGRAPHX_STREAM_SYNC
for adding the following

- remove excess hipStreamSyncronize to nullstream on CopyTensor calls
- Add proper call for stream synchronized CopyTensorAsync for
DeviceToHost case

Without this change subsequent CopyTensorAsync() calls will fail for
cards that don't use pinned memory thus causing hipMemcpy() calls to
occur before certain kernel operations occur.

![image](https://github.com/microsoft/onnxruntime/assets/107195283/4915c18a-fb2d-40c9-a50e-a7c6613c324b)

becomes

![image](https://github.com/microsoft/onnxruntime/assets/107195283/f661acf4-e2af-4c9a-b26a-30fca339cf1d)

---------

Co-authored-by: Ted Themistokleous <tthemist@amd.com>
    @TedThemistokleous
    TedThemistokleous and TedThemistokleous committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5d285b0 View commit details
    Browse the repository at this point in the history