Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.4 Build warnings preventing build #3

Merged

Conversation

jpvillam-amd
Copy link

Mainly signed unsigned comparisons
and this issue with anonymous namespace

                 from /opt/rocm/include/gtest/gtest.h:67,
                 from /workspace/github/onnxruntime/onnxruntime/test/util/include/asserts.h:8,
                 from /workspace/github/onnxruntime/onnxruntime/test/framework/session_state_test.cc:6:
/opt/rocm/include/gtest/internal/gtest-param-util.h: In instantiation of ‘class testing::internal::ParameterizedTestFactory<onnxruntime::test::SessionStateTestP_TestInitializerProcessing_Test>’:
/opt/rocm/include/gtest/internal/gtest-param-util.h:439:12:   required from ‘testing::internal::TestFactoryBase* testing::internal::TestMetaFactory<TestSuite>::CreateTestFactory(testing::internal::TestMetaFactory<TestSuite>::ParamType) [with TestSuite = onnxruntime::test::SessionS
tateTestP_TestInitializerProcessing_Test; testing::internal::TestMetaFactory<TestSuite>::ParamType = onnxruntime::test::{anonymous}::TestParam]’
/opt/rocm/include/gtest/internal/gtest-param-util.h:438:20:   required from here
/opt/rocm/include/gtest/internal/gtest-param-util.h:394:7: error: ‘testing::internal::ParameterizedTestFactory<onnxruntime::test::SessionStateTestP_TestInitializerProcessing_Test>’ has a field ‘testing::internal::ParameterizedTestFactory<onnxruntime::test::SessionStateTestP_TestIn
itializerProcessing_Test>::parameter_’ whose type uses the anonymous namespace [-Werror=subobject-linkage]
  394 | class ParameterizedTestFactory : public TestFactoryBase {
      |       ^~~~~~~~~~~~~~~~~~~~~~~~

@jpvillam-amd
Copy link
Author

@groenenboomj First time opening a PR for onnx. Should I also open a PR for master? Anyone else I needs as a reviewer?

@jpvillam-amd jpvillam-amd changed the title 5.4 Build warnings. 5.4 Build warnings preventing build Oct 19, 2022
@jeffdaily
Copy link
Collaborator

@groenenboomj First time opening a PR for onnx. Should I also open a PR for master? Anyone else I needs as a reviewer?

Yes please open an upstream PR, as well. In the meantime I will merge this into the 5.4 testing branch to unblock.

@jeffdaily jeffdaily merged commit e362da0 into ROCm:rocm5.4_internal_testing Oct 25, 2022
jeffdaily pushed a commit that referenced this pull request Jul 14, 2023
Fix memory leak issue which comes from TRT EP's allocator object not
being released upon destruction.
Following is the log from valgrind:
```
==1911860== 100,272 (56 direct, 100,216 indirect) bytes in 1 blocks are definitely lost in loss record 1,751 of 1,832
==1911860==    at 0x483CFA3: operator new(unsigned long) (vg_replace_malloc.c:472)
==1911860==    by 0x315DC2: std::_MakeUniq<onnxruntime::OrtAllocatorImplWrappingIAllocator>::__single_object std::make_unique<onnxruntime::OrtAllocatorImplWrappingIAllocator, std::shared_ptr<onnxruntime::IAllocator> >(std::shared_ptr<onnxruntime::IAllocator>&&) (unique_ptr.h:857)
==1911860==    by 0x30EE7B: OrtApis::KernelContext_GetAllocator(OrtKernelContext const*, OrtMemoryInfo const*, OrtAllocator**) (custom_ops.cc:121)
==1911860==    by 0x660D115: onnxruntime::TensorrtExecutionProvider::Compile(std::vector<onnxruntime::IExecutionProvider::FusedNodeAndGraph, std::allocator<onnxruntime::IExecutionProvider::FusedNodeAndGraph> > const&, std::vector<onnxruntime::NodeComputeInfo, std::allocator<onnxruntime::NodeComputeInfo> >&)::{lambda(void*, OrtApi const*, OrtKernelContext*)#3}::operator()(void*, OrtApi const*, OrtKernelContext*) const (tensorrt_execution_provider.cc:2223)
```
This issue happens after this [EP allocator
refactor](microsoft#15833)
groenenboomj pushed a commit that referenced this pull request Sep 26, 2023
### Description
Release OrtEnv before main function returns. Before this change, OrtEnv
is deleted when C/C++ runtime destructs all global variables in ONNX
Runtime's core framework.
The callstack is like this:
```
  * frame #0: 0x00007fffee39f5a6 libonnxruntime.so.1.16.0`onnxruntime::Environment::~Environment(this=0x00007fffee39fbf2) at environment.h:20:7
    frame #1: 0x00007fffee39f614 libonnxruntime.so.1.16.0`std::default_delete<onnxruntime::Environment>::operator()(this=0x00007ffff4c30e50, __ptr=0x0000000005404b00) const at unique_ptr.h:85:2
    frame #2: 0x00007fffee39edca libonnxruntime.so.1.16.0`std::unique_ptr<onnxruntime::Environment, std::default_delete<onnxruntime::Environment>>::~unique_ptr(this=0x5404b00) at unique_ptr.h:361:17
    frame #3: 0x00007fffee39e2ab libonnxruntime.so.1.16.0`OrtEnv::~OrtEnv(this=0x00007ffff4c30e50) at ort_env.cc:43:1
    frame #4: 0x00007fffee39fa96 libonnxruntime.so.1.16.0`std::default_delete<OrtEnv>::operator()(this=0x00007fffefff8f78, __ptr=0x00007ffff4c30e50) const at unique_ptr.h:85:2
    frame #5: 0x00007fffee39f394 libonnxruntime.so.1.16.0`std::unique_ptr<OrtEnv, std::default_delete<OrtEnv>>::~unique_ptr(this=0x7ffff4c30e50) at unique_ptr.h:361:17
    frame #6: 0x00007ffff78574b5 libc.so.6`__run_exit_handlers + 261
    frame #7: 0x00007ffff7857630 libc.so.6`exit + 32
    frame #8: 0x00007ffff783feb7 libc.so.6`__libc_start_call_main + 135
    frame #9: 0x00007ffff783ff60 libc.so.6`__libc_start_main@@GLIBC_2.34 + 128
    frame #10: 0x0000000000abbdee node`_start + 46
```
After this change, OrtEnv will be deleted before the main function
returns and nodejs is still alive.
xinyazhang pushed a commit that referenced this pull request Aug 22, 2024
### Description
Security fuzz test with address sanitizer found several bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants