rocAL Video Reader : Support to pass filenames and labels as list #89

fiona-gladwin · 2024-01-16T12:27:27Z

Add support to pass filenames and labels as list in Video reader
Add changes in rocalVideo iterator to return labels
Add new python example which demonstrates passing filenames and labels as input to the reader
Add C++ test case for the filenames case

…ader

… video_labels

Add this for VideoLabelReader

rrawther · 2024-01-17T00:06:05Z

rocAL/include/api/rocal_api_data_loaders.h

@@ -627,6 +629,7 @@ extern "C" RocalImage ROCAL_API_CALL rocalVideoFileSource(RocalContext context,
                                                          RocalDecodeDevice rocal_decode_device,
                                                          unsigned internal_shard_count,
                                                          unsigned sequence_length,
+                                                          std::vector<std::string> file_names_list = {},


pass as a reference instead and remove the default initialition. Applies to all others. If it is read_only, please make it const

rrawther · 2024-01-17T00:07:32Z

rocAL/include/api/rocal_api_meta_data.h

 * False : when the inputs from text file is to considered as timestamps.
 * \return RocalMetaData object, can be used to inquire about the rocal's output (processed) tensors
 */
-extern "C" RocalMetaData ROCAL_API_CALL rocalCreateVideoLabelReader(RocalContext rocal_context, const char *source_path, unsigned sequence_length, unsigned frame_step, unsigned frame_stride, bool file_list_frame_num = true);
+extern "C" RocalMetaData ROCAL_API_CALL rocalCreateVideoLabelReader(RocalContext rocal_context, const char *source_path, unsigned sequence_length, unsigned frame_step, unsigned frame_stride, bool file_list_frame_num = true,
+                                                                    std::vector<std::string> file_names_list = {}, std::vector<int> labels = {});


please pass those as reference instead like const std::vectorstd::string&

rrawther · 2024-01-18T01:41:37Z

rocAL/source/api/rocal_api_meta_data.cpp

@@ -67,12 +67,13 @@ ROCAL_API_CALL rocalCreateLabelReader(RocalContext p_context, const char* source
 }

 RocalMetaData
-ROCAL_API_CALL rocalCreateVideoLabelReader(RocalContext p_context, const char* source_path, unsigned sequence_length, unsigned frame_step, unsigned frame_stride, bool file_list_frame_num) {
+ROCAL_API_CALL rocalCreateVideoLabelReader(RocalContext p_context, const char* source_path, unsigned sequence_length, unsigned frame_step, unsigned frame_stride, bool file_list_frame_num,


As mentioned before please pass vectors by reference

rrawther · 2024-01-18T16:35:17Z

rocAL_pybind/examples/rocAL_api_video_labels_pipeline.py

+        self.w = self.loader.getOutputWidth()
+        self.h = self.loader.getOutputHeight()
+        self.n = self.loader.getOutputImageCount()
+        self.rim = self.loader.getRemainingImages()


What is remaining images means to video? Please change the name to describe correctly (Is it same as dataset_size?)

Renamed to self.remaining_sequences = self.loader.getRemainingImages()

rocAL_pybind/examples/rocAL_api_video_labels_pipeline.py

rrawther · 2024-01-18T16:38:25Z

tests/cpp_api_tests/rocAL_video_unittests/rocAL_video_unittests.cpp

@@ -189,7 +210,7 @@ int main(int argc, const char **argv)
        default:
        {
            std::cout << "\n>>>> VIDEO READER\n";
-            input1 = rocalVideoFileSource(handle, source_path, color_format, decoder_mode, shard_count, sequence_length, shuffle, is_output, false, frame_step, frame_stride, file_list_frame_num);
+            input1 = rocalVideoFileSource(handle, source_path, color_format, decoder_mode, shard_count, sequence_length, {}, shuffle, is_output, false, frame_step, frame_stride, file_list_frame_num);


instead of passing an empty structure, please pass 0 or nullptr which can be used if passed as reference

We will not be able to pass 0 or nullptr to vector argument hence passing as empty vector.

rrawther

please address review comments

fiona-gladwin · 2024-01-19T15:51:08Z

please address review comments

@rrawther Addressed all review comments, Please check

LakshmiKumar23 · 2024-01-23T18:20:21Z

@fiona-gladwin @rrawther why is this PR going to master? We have develop for all the tensor work.

fiona-gladwin · 2024-01-24T04:39:06Z

@fiona-gladwin @rrawther why is this PR going to master? We have develop for all the tensor work.

@LakshmiKumar23 We have added these changes to master since this was requested by a user, The develop branch has tensor related changes and is not yet merged with master branch.

kiritigowda · 2024-01-24T22:04:05Z

@rrawther - let me know if we can merge to master

rrawther · 2024-01-25T00:37:55Z

rocAL/include/meta_data/meta_data_reader.h

@@ -80,6 +82,10 @@ struct MetaDataConfig
    unsigned out_img_height() const { return _out_img_height; }
    void set_out_img_width(unsigned out_img_width) { _out_img_width = out_img_width; }
    void set_out_img_height(unsigned out_img_height) { _out_img_height = out_img_height; }
+    std::vector<std::string> file_names() const { return _file_names; }
+    std::vector<int> labels() const { return _labels; }
+    void set_file_names(std::vector<std::string> file_names) { _file_names = file_names; }


Please take these arguments by reference instead since it is passed by reference

rrawther

@fiona-gladwin : added comment in passing vectors. Also please merge tot

fiona-gladwin · 2024-01-25T14:09:35Z

@fiona-gladwin : added comment in passing vectors. Also please merge tot

Addressed review comments and merged with TOT

rrawther

@hansely: Can you please test this PR?

hansely · 2024-01-27T01:06:36Z

@rrawther
Verified that the tests are passing.
@fiona-gladwin
Before merging the PR, would you be able to update the README file in the cpp_api_test for video label case?(case =4)

rrawther · 2024-01-29T19:16:07Z

@kiritigowda : this PR can be merged . But it uses ROCAL_DATA and we don't have that in ROCm. We can merge it and create the DATA repo and update readme afterwards

kiritigowda · 2024-02-07T06:34:40Z

Merge pending - http://math-ci.amd.com/blue/organizations/jenkins/main%2Fprecheckin%2FrocAL/detail/PR-89/1/pipeline

rrawther · 2024-02-13T16:46:40Z

@kiritigowda : I think the PR was meant for develop branch for tensor. So it has to be merged to develop
@fiona-gladwin : Can you please confirm

fiona-gladwin · 2024-02-13T17:03:59Z

@kiritigowda : I think the PR was meant for develop branch for tensor. So it has to be merged to develop @fiona-gladwin : Can you please confirm

@rrawther We have added these changes to master branch since this was requested by a user, Please let me know if this needs to be added to the develop branch and I can issue a different PR for the same

sampath1117 and others added 17 commits January 12, 2024 12:20

made changes in video pipeline to accept filenames and labels from re…

f4f7062

…ader

resolved build issues

95434f5

Add labels output in Video Iterator

df901eb

Merge branch 'video_new' of https://github.com/sampath1117/rocAL into…

35d9258

… video_labels

Add support to pass filenames to Video dataloader

5dd0ccc

Change labels from string to int

64a7a85

Add this for VideoLabelReader

Minor changes

34c9979

Add python example to pass video filename with labels

732778c

Revert video pipeline example changes

5b14d00

Add reader test case in bash file

26f775d

Minor change

809f2c1

Add condition to check mutually exclusive inputs

7d8fe36

Extend filenames support for other vide readers

5979f23

Add condition check for empty input args

fc39cff

Remove unused imports

c3fd57f

Fix rocal video unit test

61f34d8

Add C++ test case for filenames list

027c883

rrawther requested review from kiritigowda and LakshmiKumar23 January 16, 2024 16:21

rrawther reviewed Jan 17, 2024

View reviewed changes

rrawther reviewed Jan 18, 2024

View reviewed changes

fiona-gladwin added 2 commits January 18, 2024 02:04

Minor change doc

30ac725

Pass filenames and labels as const reference

3c63f04

rrawther reviewed Jan 18, 2024

View reviewed changes

rocAL_pybind/examples/rocAL_api_video_labels_pipeline.py Show resolved Hide resolved

rrawther reviewed Jan 18, 2024

View reviewed changes

rrawther requested changes Jan 18, 2024

View reviewed changes

Minor change

6b122a9

kiritigowda requested a review from rrawther January 23, 2024 13:50

kiritigowda self-assigned this Jan 23, 2024

kiritigowda added the enhancement New feature or request label Jan 23, 2024

rrawther reviewed Jan 25, 2024

View reviewed changes

fiona-gladwin added 3 commits January 25, 2024 08:51

Pass and return filenames and labels as const ref

d20b68a

Merge branch 'master' of https://github.com/ROCm/rocAL into video_labels

debcbdc

Minor change

9f21aa5

rrawther approved these changes Jan 25, 2024

View reviewed changes

fiona-gladwin requested review from saadrahim and LisaDelaney as code owners January 29, 2024 17:39

Update README for video labels cpp tests

d32cfaf

fiona-gladwin force-pushed the video_labels branch from 593d2bc to d32cfaf Compare January 30, 2024 03:39

kiritigowda approved these changes Feb 13, 2024

View reviewed changes

kiritigowda merged commit bd334c8 into ROCm:master Feb 13, 2024
2 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rocAL Video Reader : Support to pass filenames and labels as list #89

rocAL Video Reader : Support to pass filenames and labels as list #89

fiona-gladwin commented Jan 16, 2024

rrawther Jan 17, 2024 •

edited

Loading

fiona-gladwin Jan 18, 2024

rrawther Jan 17, 2024

fiona-gladwin Jan 18, 2024

rrawther Jan 18, 2024

fiona-gladwin Jan 18, 2024

rrawther Jan 18, 2024

fiona-gladwin Jan 19, 2024

rrawther Jan 18, 2024

fiona-gladwin Jan 18, 2024

rrawther left a comment

fiona-gladwin commented Jan 19, 2024

LakshmiKumar23 commented Jan 23, 2024

fiona-gladwin commented Jan 24, 2024 •

edited

Loading

kiritigowda commented Jan 24, 2024

rrawther Jan 25, 2024

fiona-gladwin Jan 25, 2024

rrawther left a comment

fiona-gladwin commented Jan 25, 2024

rrawther left a comment

hansely commented Jan 27, 2024

rrawther commented Jan 29, 2024

kiritigowda commented Feb 7, 2024

rrawther commented Feb 13, 2024

fiona-gladwin commented Feb 13, 2024

rocAL Video Reader : Support to pass filenames and labels as list #89

rocAL Video Reader : Support to pass filenames and labels as list #89

Conversation

fiona-gladwin commented Jan 16, 2024

rrawther Jan 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rrawther left a comment

Choose a reason for hiding this comment

fiona-gladwin commented Jan 19, 2024

LakshmiKumar23 commented Jan 23, 2024

fiona-gladwin commented Jan 24, 2024 • edited Loading

kiritigowda commented Jan 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rrawther left a comment

Choose a reason for hiding this comment

fiona-gladwin commented Jan 25, 2024

rrawther left a comment

Choose a reason for hiding this comment

hansely commented Jan 27, 2024

rrawther commented Jan 29, 2024

kiritigowda commented Feb 7, 2024

rrawther commented Feb 13, 2024

fiona-gladwin commented Feb 13, 2024

rrawther Jan 17, 2024 •

edited

Loading

fiona-gladwin commented Jan 24, 2024 •

edited

Loading