Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CMake to respect GPU_TARGETS variable #257

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Change CMake to respect GPU_TARGETS variable #257

wants to merge 2 commits into from
+7 −2

Conversation

lawruble13
Copy link
Contributor

Summary of proposed changes:

  • Change the CMake to set the GPU_TARGETS variable from AMDGPU_TARGETS if not set by the user
  • Change all usages of AMDGPU_TARGETS to GPU_TARGETS

ntrost57
ntrost57 reviewed Oct 30, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
eidenyoshida pushed a commit that referenced this pull request Nov 20, 2024
@dependabot
Bump rocm-docs-core from 1.4.0 to 1.4.1 in /docs/sphinx (#257)
47730c6 
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lawruble13 lawruble13 requested a review from kliegeois as a code owner January 16, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntrost57 ntrost57 ntrost57 left review comments

@YvanMokwinski YvanMokwinski YvanMokwinski approved these changes

@jsandham jsandham Awaiting requested review from jsandham jsandham is a code owner

@kliegeois kliegeois Awaiting requested review from kliegeois kliegeois is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lawruble13 @YvanMokwinski @ntrost57 @jsandham