Change default compiler in install script to hipcc #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eidenyoshida
requested review from
malcolmroberts,
feizheng10,
saadrahim and
amdkila
|
Is hcc even available in 3.5? |
Not in the RC |
feizheng10
approved these changes
May 25, 2020
amdkila
approved these changes
May 25, 2020
|
Please move to internal. |
|
This is a hotfix for a release candidate branch. The code is not intended for develop. |
|
@malcolmroberts What is the process to patch a release candidate branch? |
|
Sorry; I hadn't noticed that this was a hotfix. This would be the appropriate merge path in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting master-rocm-3.5 branch. As hcc will be deprecated for 3.5, this change will make installation easier for end users. Complete removal of hcc can be done in develop for 3.6