Adding dummy target to LinalgNaedStructuredOps yamlgen #669
Conversation
jerryyin
changed the title
|
When I run the larger test with the add-dummy-dependency branch: [ 36%] Generating LinalgNamedStructuredOps.yamlgen.td, LinalgNamedStructuredOps.yamlgen.cpp.inc which is the familiar generate-three-times pattern. I can't tell at this level if they're being serialised. But it can't hurt to try it. |
|
There's probably nothing we can do about the 3 times calling of |
Should hopefully address https://github.com/ROCmSoftwarePlatform/llvm-project-private/issues/524 but no guarantee.
This is based on the assumption that makefile used by dev-ops has a bug and used file to synchronize instead of target. The idea of the change is to insert a dummy generation step to force make wait on the previous custom command.
After insertion of this dummy target, the generation sequence of
MLIRLinalgOpsIncGenis:In summary, the dummy target enforce a synchronization point to happen after the
.cpp.incand.yamlgen.tdfile generation; As well as a synchronization point to happen before the actual tablegen steps that follows it. In my observation, the generation of dummy file will block subsequent steps until it is done.