Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version number and changelog for ROCm 6.1 #169

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Update version number and changelog for ROCm 6.1 #169

merged 2 commits into from
Feb 12, 2024

Conversation

cgmb
Copy link
Collaborator

@cgmb cgmb commented Feb 8, 2024

No description provided.

lawruble13
lawruble13 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@lawruble13 lawruble13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we explicitly note that find_package(ROCM [...]) will still work via a compatibility layer?

Aside from that question, this looks good to me, so unless you feel that needs adding I'm okay with this being merged.

@cgmb cgmb merged commit 133820e into ROCm:release-staging/rocm-rel-6.1 Feb 12, 2024
4 of 8 checks passed
@cgmb cgmb deleted the update-6.1-changelog branch February 12, 2024 20:13
cgmb added a commit that referenced this pull request Apr 30, 2024
@cgmb
Merge pull request #171 from cgmb/release-staging/rocm-rel-6.1
b79ede5 
Merge ROCm 6.1 staging into develop (#169)
samjwu pushed a commit to samjwu/rocm-cmake that referenced this pull request Jul 11, 2024
@cgmb @samjwu
Update version number and changelog for ROCm 6.1 (ROCm#169)
36aeac1
samjwu added a commit that referenced this pull request Jul 15, 2024
@samjwu @cgmb
Update version number and changelog for ROCm 6.1 (#169) (#209)
a452962 
* Update version number and changelog for ROCm 6.1 (#169)

* Update version in CMakeLists.txt to match changelog (#210)

* Update version in CMakeLists.txt to match changelog

* Fix markdownlint formatting in changelog

---------

Co-authored-by: Cory Bloor <Cordell.Bloor@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawruble13 lawruble13 lawruble13 approved these changes

@pfultz2 pfultz2 Awaiting requested review from pfultz2 pfultz2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgmb @lawruble13