doc reorg with src folder #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randyh62
requested review from
pfultz2,
lawruble13,
cgmb and
a team
as code owners
lpaoletti
reviewed
Jun 10, 2024
lpaoletti
reviewed
Jun 10, 2024
lpaoletti
reviewed
Jun 10, 2024
lpaoletti
reviewed
Jun 10, 2024
lpaoletti
approved these changes
Jun 14, 2024
randyh62
requested review from
a team and
lpaoletti
and removed request for
lpaoletti
lpaoletti
approved these changes
Jun 14, 2024
randyh62
requested review from
a team and
lpaoletti
and removed request for
lpaoletti
lpaoletti
approved these changes
Jun 14, 2024
peterjunpark
approved these changes
Jun 14, 2024
|
I think this looks good, @lawruble13 @cgmb do you have any feedback on this PR? |
|
@cgmb and @lawruble13 - please review this PR and share your feedback |
cgmb
approved these changes
Aug 16, 2024
Comment on lines
+19
to
+21
| consistency across these different components. ROCm CMake build tools are primarily | ||
| used when building a library, and as such are not runtime dependencies for any generated | ||
| libraries, packages, or executables. |
There was a problem hiding this comment.
I would like to ensure we mention that the ROCm CMake build tools are not required for building programs that depend on ROCm. It's a very common point of confusion.
Comment on lines
+19
to
+20
| consistency across these different components. ROCm CMake build tools are primarily | ||
| used when building a library, and as such are not runtime dependencies for any generated |
There was a problem hiding this comment.
Instead of "primarily used when building a library," could we be more specific and mention that they're used during development too? e.g., "The ROCm CMake build tools are used when building and developing many AMD ROCm libraries, but are not runtime dependencies for any libraries, packages or executables."
randyh62
added a commit
that referenced
this pull request
Aug 21, 2024
* doc reorg with src folder (#195) * doc reorg with src folder * leo's comments * added Files and Content * Update codeowners for docs * reorg based on Paul's feedback --------- Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * add Cory's comments --------- Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
randyh62
added a commit
that referenced
this pull request
Aug 21, 2024
* doc reorg with src folder (#195) * doc reorg with src folder * leo's comments * added Files and Content * Update codeowners for docs * reorg based on Paul's feedback --------- Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com> * add Cory's comments --------- Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorganized docs presentation using the current docs/src folder configuration