Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off ROCM_SYMLINK_LIBS by default #199

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Turn off ROCM_SYMLINK_LIBS by default #199

merged 1 commit into from
Jun 14, 2024

Conversation

ahsan-ca
Copy link
Contributor

@ahsan-ca ahsan-ca commented Jun 13, 2024 •
edited
Loading

This PR turns off ROCM_SYMLINK_LIBS off by default.

@ahsan-ca ahsan-ca self-assigned this Jun 13, 2024
@ahsan-ca ahsan-ca changed the title Turn ROCM_SYMLINK_LIBS OFF by default Turn off ROCM_SYMLINK_LIBS by default Jun 13, 2024
@ahsan-ca
Copy link
Contributor Author

ahsan-ca commented Jun 13, 2024 •
edited
Loading

@cgmb @lawruble13 I discussed with @pfultz2 to turn off ROCM_SYMLINK_LIBS flag by default. Just wanted to bring this to your attention so you can comment if there is any objection to turning it off by default. Thanks!

cgmb
cgmb approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@cgmb cgmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The team discussed this recently. It should have been disabled by default when we disabled the wrapper headers.

@ahsan-ca ahsan-ca requested a review from umangyadav June 14, 2024 20:48
@ahsan-ca ahsan-ca linked an issue Jun 14, 2024 that may be closed by this pull request
Turn ROCM_SYMLINK_LIBS flag in rocm-cmake to off by default ROCm/AMDMIGraphX#3187
Closed
@ahsan-ca ahsan-ca mentioned this pull request Jun 14, 2024
Closed
@pfultz2 pfultz2 merged commit 008acef into develop Jun 14, 2024
16 checks passed
@pfultz2 pfultz2 deleted the symlink-libs-off branch June 14, 2024 21:28
ahsan-ca added a commit that referenced this pull request Jun 25, 2024
@ahsan-ca
Turn ROCM_SYMLINK_LIBS OFF by default (#199)
743508f
amd-aakash pushed a commit that referenced this pull request Jul 9, 2024
@ahsan-ca @pfultz2 @lawruble13
Cherry-pick private lib changes into release 6.2 (#205)
aa86563 
* Add flag to move libraries under project name (#188)

Co-authored-by: Paul Fultz II <pfultz2@yahoo.com>

* Turn ROCM_SYMLINK_LIBS OFF by default (#199)

* Update RPATH to binaries for PRIVATE lib changes (#197)

* Update RPATHs

* Remove debug messages and re-indent comments

* Use CMP0095 NEW policy for paths and update BIN_INSTALL_DIR paths for private binaries

* Remove setting CMP0095 to NEW

* Add RPATH to tests to point to private libraries. (#200)

* Add RPATH to tests to point to private libraries.

* Fix relative path to lib

---------

Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>

---------

Co-authored-by: Paul Fultz II <pfultz2@yahoo.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangyadav umangyadav umangyadav approved these changes

@cgmb cgmb cgmb approved these changes

@pfultz2 pfultz2 Awaiting requested review from pfultz2 pfultz2 is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees

@ahsan-ca ahsan-ca

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn ROCM_SYMLINK_LIBS flag in rocm-cmake to off by default
4 participants
@ahsan-ca @cgmb @umangyadav @pfultz2