Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scale down z-axis of multiple elements to prevent covering flyout #1077

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

alexxu-amd
Copy link
Contributor

@alexxu-amd alexxu-amd commented Dec 31, 2024

The new flyout feature introduced by readthedocs has z-index set to 3000. I'm scaling down our z-index setting to prevent the flyout being covered by other elements.

image
image

@alexxu-amd alexxu-amd changed the title fix: reducing sidebar z-index fix: scale down z-axis of multiple elements to prevent covering flyout Dec 31, 2024
@alexxu-amd alexxu-amd marked this pull request as ready for review December 31, 2024 19:31
Copy link
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think a comment in the code about why the value was selected is warranted?

@alexxu-amd alexxu-amd merged commit a67b29b into develop Jan 2, 2025
7 checks passed
@alexxu-amd alexxu-amd deleted the alexxu12/flyoutZIndex branch January 2, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants