Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes #444

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Style fixes #444

merged 3 commits into from
Oct 18, 2023

Conversation

Maetveis
Copy link
Contributor

  • Switch to dedicated formatter extension for vscode and gitpod

The built-in support of formatters in the python extension is
deprecated, and the functionality has been broken out to individual
extensions.
Let's use the new extensions for devcontainers, both vscode and gitpod.

More details can be found at:
https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions

  • Enable more linting checks from our code linters ruff and fix them

Based on #443 and #441, to avoid conflicts.

@Maetveis Maetveis requested review from samjwu and saadrahim and removed request for samjwu October 16, 2023 13:33
Gergely Meszaros added 3 commits October 17, 2023 08:58
The built-in support of formatters in the python extension is
deprecated, and the functionality has been broken out to individual
extensions.
Let's use the new extensions for devcontainers, both vscode and gitpod.

More details can be found at:
https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions
@Maetveis Maetveis merged commit 57ee6aa into ROCm:develop Oct 18, 2023
7 checks passed
@Maetveis Maetveis deleted the style_fixes branch October 18, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants