Skip to content

Commit

Permalink
Fix typo, patch issue in kernel filtering in standalone GUI, and erro…
Browse files Browse the repository at this point in the history
…r on version mismatch

Signed-off-by: colramos-amd <colramos@amd.com>
  • Loading branch information
coleramos425 committed Mar 3, 2024
1 parent ca59cbe commit ea9783f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
3 changes: 2 additions & 1 deletion src/utils/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -881,8 +881,9 @@ def apply_filters(workload, dir, is_gui, debug):
ret_df[schema.pmc_perf_file_prefix]["Kernel_Name"].isin(kernels)
]
elif all(type(kid) == str for kid in workload.filter_kernel_ids):
df_cleaned = ret_df[schema.pmc_perf_file_prefix]["Kernel_Name"].apply(lambda x: x.strip() if isinstance(x, str) else x)
ret_df = ret_df.loc[
ret_df[schema.pmc_perf_file_prefix]["Kernel_Name"].isin(
df_cleaned.isin(
workload.filter_kernel_ids
)
]
Expand Down
11 changes: 8 additions & 3 deletions src/utils/specs.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,16 @@ def __init__(self, *args, **kwargs):

def generate_machine_specs(args, sysinfo: dict = None):
if not sysinfo is None:
sysinfo_ver = str(sysinfo["version"])
try:
sysinfo_ver = str(sysinfo["version"])
except KeyError:
error(
"Detected mismatch in sysinfo versioning. You need to reprofile to update data."
)
version = get_version(config.omniperf_home)["version"]
if sysinfo_ver != version[: version.find(".")]:
logging.warning(
"WARNING: Detected mismatch in sysinfo versioning. You may need to reprofile to update data."
error(
"Detected mismatch in sysinfo versioning. You need to reprofile to update data."
)
return MachineSpecs(**sysinfo)
# read timestamp info
Expand Down
2 changes: 1 addition & 1 deletion src/utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def run_rocscope(args, fname):


def mibench(args, mspec):
"""Run roofline microbenchmark to generate peak BW and FLOP measurements."""
"""Run roofline microbenchmark to generate peek BW and FLOP measurements."""
logging.info("[roofline] No roofline data found. Generating...")
distro_map = {"platform:el8": "rhel8", "15.3": "sle15sp3", "20.04": "ubuntu20_04"}

Expand Down

0 comments on commit ea9783f

Please sign in to comment.