Initial overhaul of Analyze mode #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
koomie
reviewed
Dec 7, 2023
koomie
reviewed
Dec 7, 2023
koomie
reviewed
Dec 7, 2023
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
…r clarity Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
|
Added a new property to our base class |
Signed-off-by: Cole Ramos <colramos@amd.com>
koomie
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the changes below for the initial implementation of our revised Analysis mode. Again, this has only been verified on a Mi200 + rocprofv1 environment. Once this is merged into the main
2.xbranch we can conduct additional verification against our CI pipeline.A couple changes to call attention to:
https://github.com/AMDResearch/omniperf/blob/4275e15eea222e2bd7f6b18ea2c66b95d4f07904/src/argparser.py#L410-L415
https://github.com/AMDResearch/omniperf/blob/4275e15eea222e2bd7f6b18ea2c66b95d4f07904/src/utils/file_io.py#L237-L245
We've removed instances of hardcoded lists, and instead read from archs defined in src/omniperf_soc/
src/utils/directory