-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mi300 to 2.x #231
Merged
Merged
Adding Mi300 to 2.x #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koomie
reviewed
Jan 23, 2024
koomie
reviewed
Jan 23, 2024
koomie
reviewed
Jan 23, 2024
koomie
reviewed
Jan 23, 2024
koomie
reviewed
Jan 23, 2024
koomie
reviewed
Jan 23, 2024
koomie
reviewed
Jan 23, 2024
koomie
reviewed
Jan 23, 2024
koomie
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few minor comments for consideration.
…g fields. Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
… specific to rocprof ver Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
…l counter updates Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
…ck num Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
…ed to new format Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
…modes Co-authored-by: fei.zheng <fei.zheng@amd.com> Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
coleramos425
force-pushed
the
2.x-mi300
branch
from
January 24, 2024 22:18
cbbd4fe
to
ab1acb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds Mi300 support from our
mi300
branch into the2.x
redesign. I've tested these changes on all of the Mi300 varients that we'll be supporting.From now on, our "source of truth" for supported SoC's is the
__supported_archs
property of the mainOmniperf()
class. This value is passed to all sub-classes that need this arch -> GPU name mapping.https://github.com/AMDResearch/omniperf/blob/131429087b1fe7ec6997c554c7e2f9069d8a057b/src/omniperf_base.py#L50-L57
Major Changes
https://github.com/AMDResearch/omniperf/blob/131429087b1fe7ec6997c554c7e2f9069d8a057b/src/utils/utils.py#L246-L271
MachineSpecs()
properties with improved naming conventions and additional fields for Mi300 support (i.e., compute_partion and memory_partition)https://github.com/AMDResearch/omniperf/blob/131429087b1fe7ec6997c554c7e2f9069d8a057b/src/utils/specs.py#L38-L65
--specs-correction
. At any time, peek current machine specs via--specs
https://github.com/AMDResearch/omniperf/blob/df6471db54f3f2cd97dfa69983a14f15957ac43d/src/omniperf_soc/analysis_configs/gfx940/1800_L2_cache_per_channel.yaml#L136-L151
cli_style
property which can define infographic style for CLI analysis view--list-metrics
implementation to highlight both individual metrics in addition to sections that can be toggled, i.e.Notes
mi300
branch. This will not be merged upstream until the PyPi module is updated. Current ETA is ~ MarchAttributeError: module 'plotext' has no attribute 'box' piccolomo/plotext#196 (comment)
Special thanks to @feizheng10 for his contributions in this PR.