Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor enhancements for log output #317

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Minor enhancements for log output #317

merged 2 commits into from
Mar 14, 2024

Conversation

koomie
Copy link
Collaborator

@koomie koomie commented Mar 14, 2024

  1. make ERROR output consistent when color is enabled/disabled
  2. assign color to custom TRACE level
  3. justify levelname output when color is enabled

This should give users a reasonable experience if they want to enable color via OMNIPERF_COLOR=1. We can revisit later what the preferred default mode should be.

koomie added 2 commits March 14, 2024 17:26
@koomie
update logging formatter handling for consistent behavior with error …
3f94f7c 
…messsages

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
@koomie
logger update: assign color for TRACE level
5febfc9 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
@koomie koomie added this to the v2.0.0 milestone Mar 14, 2024
@koomie koomie merged commit 3438bc9 into 2.x Mar 14, 2024
7 checks passed
@koomie koomie deleted the logmod branch March 14, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@koomie