Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for container build with ubuntu #343

Merged
merged 5 commits into from
Apr 19, 2024
Merged

updates for container build with ubuntu #343

merged 5 commits into from
Apr 19, 2024

Conversation

koomie
Copy link
Collaborator

@koomie koomie commented Apr 11, 2024

  • include required locale
  • install python testing deps from file
  • bump up rocm version

This PR also fixes the rhel-8 test to include necessary locale and correct installation order.

@koomie koomie added the CI Continuous Integration label Apr 11, 2024
@koomie koomie force-pushed the cimods branch 2 times, most recently from 7dcd453 to 2a903e2 Compare April 11, 2024 15:54
@koomie koomie requested a review from coleramos425 as a code owner April 19, 2024 14:46
Copy link
Collaborator

@coleramos425 coleramos425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My only suggestion is that since now .github/workflows/ubuntu-focal.yml is running on Ubuntu 22.04, we may want to change the file name to ubuntu-jammy.yml.

koomie added 5 commits April 19, 2024 12:42
* include required locale
* install python testing deps from file
* bump up rocm version

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
add glibc-langpack-en install to resolve missing locale

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
@koomie koomie merged commit 15f206a into main Apr 19, 2024
9 checks passed
@koomie koomie deleted the cimods branch April 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants