Fix kernel menu item size #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was 150 pixels. Change to 36 pixels.
coleramos425
requested changes
Apr 19, 2024
There was a problem hiding this comment.
@benrichard-amd thanks for the contribution. While the new height does work for smaller apps with simple kernel names, we run into issues when testing apps with rocblas GEMM, Kokkos, and other complicated kernel names.
I tried loading a simple all_reduce_perf into the visualizer and found your branch will display overlapping text. If you'd like to change the height of the menu items, I'd recommend enabling hidden overflow to avoid this text wrapping effect.
ROCm/rccl-tests is a good test repo if you want to reproduce my findings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #344
Change the height of the menu items from 150px to 36px.