Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctest failures #396

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Conversation

benrichard-amd
Copy link
Contributor

The recent improvement to counter coalescing results in Omniperf producing fewer files. This PR updates the test to refelct these changes.

The ctests were expecting some files to be there, but after the improved
coalescing are no longer output by omniperf.
Z
Same as MI300, the tests were looking for files no longer produced by omniperf.
Signed-off-by: benrichard-amd <ben.richard@amd.com>
Copy link
Collaborator

@coleramos425 coleramos425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like you still need to format Python (e.g. black omniperf/) and add DCO sign-off. Once that's done, lets merge and follow up with the QA team.

Signed-off-by: benrichard-amd <ben.richard@amd.com>
@benrichard-amd benrichard-amd merged commit ac98ea5 into ROCm:dev Aug 7, 2024
9 of 10 checks passed
@benrichard-amd benrichard-amd deleted the fix-ctest-failures branch August 7, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants