Tarball on rocm tags and MAINTAINERS guide #402

coleramos425 · 2024-08-09T17:33:31Z

This PR adds a MAINTAINERS.md file which outlines the procedure for publishing an Omniperf release. The guide should be shared with any project maintainers who will be publishing releases.

I've also modified the packaging.yml action such that any tags matching regex rocm-[0-9]+.[0-9]+.[0-9]+* will trigger the workflow which produces our release tarball.

TODO:

Once @dgaliffiAMD has published the amd-mainline and amd-staging branches, update the empty links in the MAINTAINERS.md file
Solicit feedback from devops team to ensure expectations are clearly communicated

…utline release procedure Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 · 2024-08-09T17:35:05Z

@koomie please feel free to add any feedback if there's anything I missed.

dgaliffiAMD

Thank you. Looks good. Just some minor formatting changes.

MAINTAINERS.md

Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 · 2024-08-16T16:14:36Z

Some feedback from ROCm devops team on this PR (via @WBobby)

CHANGELOG formatting must adhere to standard ROCm formatting for "rocm-ci" to correctly detect and copy changes to release notes. He provided this as a CHANGELOG template (https://github.com/ROCm/hipTensor/blob/develop/CHANGELOG.md)

"rocm-ci" bot will not copy the release tarball from Omniperf's packaging action. It's on us to come up with a workaround for this

TODO

I can address (1) fairly easily with some minor changes to this PR (also related to Move CHANGES to CHANGELOG.md #410).
For (2) I'll need to consult with the team on the best way to proceed.

Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 · 2024-08-20T19:13:30Z

I've modified the packaging workflow so that on a new tag (including tags matching the format rocm-x.x.x) the workflow will upload the release tarball to the corresponding release (in case of rocm-x.x.x tag, the release name "Omniperf vX.X.X for rocm-x.x.x").

https://github.com/ROCm/omniperf/blob/7441f040e0e1ad611033022f00876403123d58b4/.github/workflows/packaging.yml#L48-L62

This should comply with requirements from the DevOps team and their "rocm-ci" bot used to trigger releases.

Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 · 2024-08-28T16:47:34Z

After meeting with @arjun-raj-kuppala we've decided that instead of triggering the packaging workflow on tag, we should trigger on release and then upload the subsequent tarball artifact to the latest release as an asset. It's a little different than what I'm doing now, but should be an easy change.

Other than that, this PR complies on his end.

Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <colramos@amd.com>

Signed-off-by: coleramos425 <colramos@amd.com>

* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <colramos@amd.com> * Apply linting feedback Signed-off-by: coleramos425 <colramos@amd.com> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <colramos@amd.com> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <colramos@amd.com> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <colramos@amd.com> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <colramos@amd.com> * Synax change for release name in packaging action Signed-off-by: coleramos425 <colramos@amd.com> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <colramos@amd.com> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <colramos@amd.com> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <colramos@amd.com> --------- Signed-off-by: coleramos425 <colramos@amd.com>

* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <colramos@amd.com> * Apply linting feedback Signed-off-by: coleramos425 <colramos@amd.com> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <colramos@amd.com> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <colramos@amd.com> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <colramos@amd.com> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <colramos@amd.com> * Synax change for release name in packaging action Signed-off-by: coleramos425 <colramos@amd.com> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <colramos@amd.com> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <colramos@amd.com> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <colramos@amd.com> --------- Signed-off-by: coleramos425 <colramos@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Package release tarball on rocm tags and add a MAINTAINERS guide to o…

1b2a75e

…utline release procedure Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 requested review from a team and koomie as code owners August 9, 2024 17:33

coleramos425 requested a review from dgaliffiAMD August 9, 2024 17:33

dgaliffiAMD requested a review from WBobby August 9, 2024 17:46

dgaliffiAMD reviewed Aug 9, 2024

View reviewed changes

MAINTAINERS.md Outdated Show resolved Hide resolved

MAINTAINERS.md Outdated Show resolved Hide resolved

MAINTAINERS.md Outdated Show resolved Hide resolved

coleramos425 force-pushed the colramos/release-info branch from b9567b3 to 1b2a75e Compare August 9, 2024 20:11

coleramos425 added 2 commits August 9, 2024 20:14

Apply linting feedback

94e95af

Signed-off-by: coleramos425 <colramos@amd.com>

Update links in MAINTAINERS for new branches

849a0fd

Signed-off-by: coleramos425 <colramos@amd.com>

dgaliffiAMD approved these changes Aug 9, 2024

View reviewed changes

coleramos425 added 2 commits August 16, 2024 21:02

Update MAINTAINERS.md for changelog formatting

d43d9d0

Signed-off-by: coleramos425 <colramos@amd.com>

Update Omniperf ver checker to allow tags with rocm- prefix

8395f67

Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 force-pushed the colramos/release-info branch 2 times, most recently from 56cf357 to 8395f67 Compare August 20, 2024 18:35

coleramos425 added 2 commits August 20, 2024 18:43

Add step to packaging workflow to upload release tarball to release

ed3e3b8

Signed-off-by: coleramos425 <colramos@amd.com>

Synax change for release name in packaging action

7441f04

Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 requested a review from arjun-raj-kuppala August 20, 2024 19:17

Update MAINTAINERS for instuctions on ROCm releases

d1abb8b

Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 added the documentation Improvements or additions to documentation label Aug 22, 2024

coleramos425 added 2 commits September 24, 2024 15:28

Update softprops pluvin to v2 and remove release name

e8862b9

Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <colramos@amd.com>

Remove draft option on softprops plugin

ccc9fdf

Signed-off-by: coleramos425 <colramos@amd.com>

coleramos425 mentioned this pull request Sep 24, 2024

Add rocm tag to cpack.yml ROCm/omnitrace#389

Merged

coleramos425 merged commit 6265391 into amd-staging Sep 24, 2024
12 of 14 checks passed

coleramos425 deleted the colramos/release-info branch September 24, 2024 21:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tarball on rocm tags and MAINTAINERS guide #402

Tarball on rocm tags and MAINTAINERS guide #402

coleramos425 commented Aug 9, 2024 •

edited

Loading

coleramos425 commented Aug 9, 2024

dgaliffiAMD left a comment

coleramos425 commented Aug 16, 2024 •

edited

Loading

coleramos425 commented Aug 20, 2024 •

edited

Loading

coleramos425 commented Aug 28, 2024

Tarball on rocm tags and MAINTAINERS guide #402

Tarball on rocm tags and MAINTAINERS guide #402

Conversation

coleramos425 commented Aug 9, 2024 • edited Loading

TODO:

coleramos425 commented Aug 9, 2024

dgaliffiAMD left a comment

Choose a reason for hiding this comment

coleramos425 commented Aug 16, 2024 • edited Loading

TODO

coleramos425 commented Aug 20, 2024 • edited Loading

coleramos425 commented Aug 28, 2024

coleramos425 commented Aug 9, 2024 •

edited

Loading

coleramos425 commented Aug 16, 2024 •

edited

Loading

coleramos425 commented Aug 20, 2024 •

edited

Loading