-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MI300 rhel and sles roofline binaries #480
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,8 +34,6 @@ | |
|
||
IMGNAME = "empirRoof" | ||
|
||
L2_BANKS = 32 # default assuming mi200, mi300 | ||
|
||
XMIN = 0.01 | ||
XMAX = 1000 | ||
|
||
|
@@ -188,7 +186,7 @@ def calc_ceilings(roofline_parameters, dtype, benchmark_data): | |
# Overlay application performance | ||
# ------------------------------------------------------------------------------------- | ||
# Calculate relevant metrics for ai calculation | ||
def calc_ai(sort_type, ret_df): | ||
def calc_ai(mspec, sort_type, ret_df): | ||
"""Given counter data, calculate arithmetic intensity for each kernel in the application.""" | ||
df = ret_df["pmc_perf"] | ||
# Sort by top kernels or top dispatches? | ||
|
@@ -306,8 +304,8 @@ def calc_ai(sort_type, ret_df): | |
lds_data += ( | ||
(df["SQ_LDS_IDX_ACTIVE"][idx] - df["SQ_LDS_BANK_CONFLICT"][idx]) | ||
* 4 | ||
* L2_BANKS | ||
) # L2_BANKS = 32 (since assuming mi200 or mi300) | ||
* (mspec.lds_banks_per_cu) | ||
) | ||
except KeyError: | ||
console_debug( | ||
"roofline", | ||
|
@@ -338,37 +336,38 @@ def calc_ai(sort_type, ret_df): | |
) | ||
pass | ||
try: | ||
if df.keys().str.contains("TCC_BUBBLE").sum() > 0: | ||
# MI300 uses TCC_BUBBLE_sum to calculate hbm_data | ||
if mspec.gpu_model == "MI200": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Diff is visually messy- change made is just checking if mi200 do original calculation, otherwise do the tcc_bubble_sum calculation for mi300 and above hardware. No changes made to the actual calculations, just the if else statement by checking for gpu model and not the counter. |
||
hbm_data += ( | ||
(df["TCC_BUBBLE_sum"][idx] * 128) | ||
+ (df["TCC_EA0_RDREQ_32B_sum"][idx] * 32) | ||
(df["TCC_EA_RDREQ_32B_sum"][idx] * 32) | ||
+ ( | ||
( | ||
df["TCC_EA0_RDREQ_sum"][idx] | ||
- df["TCC_BUBBLE_sum"][idx] | ||
- df["TCC_EA0_RDREQ_32B_sum"][idx] | ||
) | ||
(df["TCC_EA_RDREQ_sum"][idx] - df["TCC_EA_RDREQ_32B_sum"][idx]) | ||
* 64 | ||
) | ||
+ (df["TCC_EA_WRREQ_64B_sum"][idx] * 64) | ||
+ ( | ||
(df["TCC_EA0_WRREQ_sum"][idx] - df["TCC_EA0_WRREQ_64B_sum"][idx]) | ||
(df["TCC_EA_WRREQ_sum"][idx] - df["TCC_EA_WRREQ_64B_sum"][idx]) | ||
* 32 | ||
) | ||
+ (df["TCC_EA0_WRREQ_64B_sum"][idx] * 64) | ||
) | ||
|
||
else: | ||
# Use TCC_BUBBLE_sum to calculate hbm_data | ||
hbm_data += ( | ||
(df["TCC_EA_RDREQ_32B_sum"][idx] * 32) | ||
(df["TCC_BUBBLE_sum"][idx] * 128) | ||
+ (df["TCC_EA0_RDREQ_32B_sum"][idx] * 32) | ||
+ ( | ||
(df["TCC_EA_RDREQ_sum"][idx] - df["TCC_EA_RDREQ_32B_sum"][idx]) | ||
( | ||
df["TCC_EA0_RDREQ_sum"][idx] | ||
- df["TCC_BUBBLE_sum"][idx] | ||
- df["TCC_EA0_RDREQ_32B_sum"][idx] | ||
) | ||
* 64 | ||
) | ||
+ (df["TCC_EA_WRREQ_64B_sum"][idx] * 64) | ||
+ ( | ||
(df["TCC_EA_WRREQ_sum"][idx] - df["TCC_EA_WRREQ_64B_sum"][idx]) | ||
(df["TCC_EA0_WRREQ_sum"][idx] - df["TCC_EA0_WRREQ_64B_sum"][idx]) | ||
* 32 | ||
) | ||
+ (df["TCC_EA0_WRREQ_64B_sum"][idx] * 64) | ||
) | ||
except KeyError: | ||
console_debug( | ||
|
Binary file not shown.
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same number (32) in the end but should be lds banks- changing to using the per-arch defined lds_banks_per_cu from soc file instead of hardcoded value.