Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move roofline plot generation to analyze mode #490

Open
wants to merge 1 commit into
base: amd-staging
Choose a base branch
from

Conversation

sohaibnd
Copy link

@sohaibnd sohaibnd commented Nov 25, 2024

This is to address #435

Still, the only thing I need would be a way to generate the roofline PDFs for a given kernel after having recorded performance counters for all kernel.

I believe that would be a useful feature because we don't want to re-profile the whole program each time we want a roofline for a different kernel. This feature seems to already exist in the GUI, I would appreciate having the same capabilities built in the CLI

By moving the creation of the roofline plot pdfs to analyze mode on cli, we can create a roofline plots with different kernel filtering without having to re-profile the whole program.

Signed-off-by: Sohaib Nadeem <sohaib.nadeem@amd.com>
@sohaibnd sohaibnd force-pushed the sonadeem_roofline_cli_analyze_mode branch from eb6468c to 6e6ad5c Compare November 25, 2024 23:51
@coleramos425
Copy link
Collaborator

@sohaibnd make sure you're also updating any CI tests that leverage the flags that are modified in this PR, i.e.,

def test_sort_kernels():

If this introduces a new "roofline" mode, we may want to add logic for this in tests to ensure it isn't being missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants