Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify test_profile_general.py ctest to include MI300 roofline #498

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

cfallows-amd
Copy link
Contributor

Currently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet.

…rently failing because of explicitly excluded roofline files for the soc and autofailed asserts for roof-only tests- originally in place because roofline was not enabled on mi300 yet.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
@coleramos425
Copy link
Collaborator

coleramos425 commented Dec 2, 2024

Looks like a duplicate of changes in #483. Fine if we want to separate the debug into different PRs, but just a heads up to reduce accidental duplication of work.

@feizheng10
Copy link
Contributor

Looks like a duplicate of changes in #483. Fine if we want to separate the debug into different PRs, but just a heads up to reduce accidental duplication of work.

Good to know! Please merge either way asap.

@cfallows-amd cfallows-amd marked this pull request as ready for review December 2, 2024 18:07
@cfallows-amd cfallows-amd requested a review from koomie as a code owner December 2, 2024 18:07
@cfallows-amd cfallows-amd merged commit 903241a into amd-staging Dec 2, 2024
8 checks passed
@cfallows-amd cfallows-amd deleted the cfallows/fix_roof_ctests branch December 9, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants