Unify all file handling with pathlib #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedithal-amd
requested review from
koomie,
a team,
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
vedithal-amd
force-pushed
the
amd-staging
branch
from
2226220 to
cfec0fe
Compare
vedithal-amd
changed the title
feizheng10
approved these changes
Dec 17, 2024
vedithal-amd
force-pushed
the
amd-staging
branch
from
59f0385 to
8019721
Compare
|
@vedithal-amd once we fix the merge conflict we can squash and merge. |
* Replace occurences of os.path functions with equivalent functions from pathlib library * Remove unwanted imports of os.path and os
* Use pathlib library functions instead of os.path for file path manipulation
vedithal-amd
force-pushed
the
amd-staging
branch
from
8019721 to
30190c1
Compare
|
@coleramos425 I have fixed the merge conflict, once the CI has passed we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace occurences of os.path functions with equivalent functions from
pathlib library
Remove unwanted imports of os.path and os
Add coding guidelines for using pathlib instead of os.path